You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/02/20 01:24:05 UTC
Review Request 18294: Update gradle wrapper to 1.11
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Repository: aurora
Description
-------
Release notes for intervening versions:
http://www.gradle.org/docs/1.9/release-notes
http://www.gradle.org/docs/1.10/release-notes
http://www.gradle.org/docs/1.11/release-notes
Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9).
$ ./gradlew htmlDependencyReport
$ open dist/reports/project/dependencies/index.html
Diffs
-----
build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
gradle/wrapper/gradle-wrapper.jar 667288ad6c2b3b87c990ece1267e56f0bcbf3622
gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345
Diff: https://reviews.apache.org/r/18294/diff/
Testing
-------
./gradlew clean build
Thanks,
Bill Farner
Re: Review Request 18294: Update gradle wrapper to 1.11
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/#review34974
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 19, 2014, 4:24 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18294/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 4:24 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes for intervening versions:
>
> http://www.gradle.org/docs/1.9/release-notes
> http://www.gradle.org/docs/1.10/release-notes
> http://www.gradle.org/docs/1.11/release-notes
>
> Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9).
>
> $ ./gradlew htmlDependencyReport
> $ open dist/reports/project/dependencies/index.html
>
>
> Diffs
> -----
>
> build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
> gradle/wrapper/gradle-wrapper.jar 667288ad6c2b3b87c990ece1267e56f0bcbf3622
> gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345
>
> Diff: https://reviews.apache.org/r/18294/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18294: Update gradle wrapper to 1.11
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/#review35019
-----------------------------------------------------------
Ship it!
Would say that what we have here now is good and if this comes up as an issue we can either automate adding a license header at that time with the gradle-license-plugin or remove gradlew and add a bootstrap script to generate it (and adding gradle* to the gitignore)
- Jake Farrell
On Feb. 20, 2014, 5:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18294/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 5:50 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes for intervening versions:
>
> http://www.gradle.org/docs/1.9/release-notes
> http://www.gradle.org/docs/1.10/release-notes
> http://www.gradle.org/docs/1.11/release-notes
>
> Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9).
>
> $ ./gradlew htmlDependencyReport
> $ open dist/reports/project/dependencies/index.html
>
>
> Diffs
> -----
>
> build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
> gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345
> gradlew b6fd1324f692cd66635e29eff3e8736f6c0be43c
>
> Diff: https://reviews.apache.org/r/18294/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18294: Update gradle wrapper to 1.11
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 5:50 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Took Jake's advice to configure the wrapper task and then effectively did a "self update". What you see is the result (mod deletion of gradlew.bat). Note that the gradle-wrapper jar is unchanged (after all, it's just a shim; not sure if/how that thing is versioned), and that the license header is removed from gradlew. Jake — what's your opinion on the license removal? I could see opinions going either way on this.
Repository: aurora
Description
-------
Release notes for intervening versions:
http://www.gradle.org/docs/1.9/release-notes
http://www.gradle.org/docs/1.10/release-notes
http://www.gradle.org/docs/1.11/release-notes
Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9).
$ ./gradlew htmlDependencyReport
$ open dist/reports/project/dependencies/index.html
Diffs (updated)
-----
build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345
gradlew b6fd1324f692cd66635e29eff3e8736f6c0be43c
Diff: https://reviews.apache.org/r/18294/diff/
Testing
-------
./gradlew clean build
Thanks,
Bill Farner
Re: Review Request 18294: Update gradle wrapper to 1.11
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/#review34963
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 20, 2014, 12:24 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18294/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 12:24 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes for intervening versions:
>
> http://www.gradle.org/docs/1.9/release-notes
> http://www.gradle.org/docs/1.10/release-notes
> http://www.gradle.org/docs/1.11/release-notes
>
> Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9).
>
> $ ./gradlew htmlDependencyReport
> $ open dist/reports/project/dependencies/index.html
>
>
> Diffs
> -----
>
> build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
> gradle/wrapper/gradle-wrapper.jar 667288ad6c2b3b87c990ece1267e56f0bcbf3622
> gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345
>
> Diff: https://reviews.apache.org/r/18294/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18294: Update gradle wrapper to 1.11
Posted by Bill Farner <wf...@apache.org>.
> On Feb. 20, 2014, 4:57 a.m., Jake Farrell wrote:
> > build.gradle, line 309
> > <https://reviews.apache.org/r/18294/diff/1/?file=498298#file498298line309>
> >
> > We should add the version of gradle in use as a task to make sure that if the wrapper is regenerated it always uses the same set version (
> > http://www.apache.org/dev/release.html#what)
> >
> > task wrapper(type: Wrapper) {
> > gradleVersion = '1.11'
> > }
> >
> >
Good call!
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/#review34980
-----------------------------------------------------------
On Feb. 20, 2014, 12:24 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18294/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 12:24 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes for intervening versions:
>
> http://www.gradle.org/docs/1.9/release-notes
> http://www.gradle.org/docs/1.10/release-notes
> http://www.gradle.org/docs/1.11/release-notes
>
> Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9).
>
> $ ./gradlew htmlDependencyReport
> $ open dist/reports/project/dependencies/index.html
>
>
> Diffs
> -----
>
> build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
> gradle/wrapper/gradle-wrapper.jar 667288ad6c2b3b87c990ece1267e56f0bcbf3622
> gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345
>
> Diff: https://reviews.apache.org/r/18294/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 18294: Update gradle wrapper to 1.11
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18294/#review34980
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/18294/#comment65373>
We should add the version of gradle in use as a task to make sure that if the wrapper is regenerated it always uses the same set version (
http://www.apache.org/dev/release.html#what)
task wrapper(type: Wrapper) {
gradleVersion = '1.11'
}
- Jake Farrell
On Feb. 20, 2014, 12:24 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18294/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 12:24 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Release notes for intervening versions:
>
> http://www.gradle.org/docs/1.9/release-notes
> http://www.gradle.org/docs/1.10/release-notes
> http://www.gradle.org/docs/1.11/release-notes
>
> Also added the 'project-report' plugin, which can generate a nice HTML dependency report (added in 1.9).
>
> $ ./gradlew htmlDependencyReport
> $ open dist/reports/project/dependencies/index.html
>
>
> Diffs
> -----
>
> build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
> gradle/wrapper/gradle-wrapper.jar 667288ad6c2b3b87c990ece1267e56f0bcbf3622
> gradle/wrapper/gradle-wrapper.properties 23ea6e137f8d386bf9cea7776dc7bf6849982345
>
> Diff: https://reviews.apache.org/r/18294/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Bill Farner
>
>