You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ponymail.apache.org by sebbASF <gi...@git.apache.org> on 2016/10/09 09:14:11 UTC

[GitHub] incubator-ponymail issue #179: Bug: code includes embedded configuration ite...

GitHub user sebbASF opened an issue:

    https://github.com/apache/incubator-ponymail/issues/179

    Bug: code includes embedded configuration items and other 'magic' items

    The code contains quite a few 'magic' numbers and strings which should be configuration choices.
    
    For example, the size = 50000 parameters in preferences.lua, and the date range { gte = "now-20y" }
    
    These values should be moved into config.lua or a similar location so they can easily be adjusted.
    
    Code should rarely (if ever) contain 'magic' numbers or strings.

----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---