[jira] [Work logged] (ARTEMIS-4206) Unreferenced AMQP Large Messages are not removed

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-4206?focusedWorklogId=854300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854300 ]

ASF GitHub Bot logged work on ARTEMIS-4206:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/23 14:35
            Start Date: 01/Apr/23 14:35
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4418:
URL: https://github.com/apache/activemq-artemis/pull/4418#discussion_r1155119030


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/LargeServerMessage.java:
##########
@@ -27,6 +27,8 @@
 
 public interface LargeServerMessage extends ReplicatedLargeMessage {
 
+   boolean DEBUG = Boolean.parseBoolean(System.getProperty("ARTEMIS_LARGE_MESSAGE_DEBUG", "false"));

Review Comment:
   I will just use logger.isDebugEnabled();
   
   if RefCountMessage.logger is debug, it will be using debug
   
   
   Maybe I will also expose the logger from RefCountMessage with RefCountMessage::isDebugEnabled()
   
   As I will be adding a method refCountMessage.addDebug(String );
   
   (Not sure I will keep this method in the final version after I figure out the issue I'm dealing with now...
     apparently a message could be duplicated after a failed AMQP Consumer in some weird race, and if I add logger.debug() the error is gone... the only way I have been able to capture this was by adding a new event to the debugState, and checking if I'm trying to remove the message twice.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 854300)
    Time Spent: 4h 20m  (was: 4h 10m)

> Unreferenced AMQP Large Messages are not removed
> ------------------------------------------------
>
>                 Key: ARTEMIS-4206
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4206
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.29.0
>
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Say you crashed the server after the ack, and before the file.remove, and the journal. record removal.
> The AMQP Large Message may not be removed right away, requiring a restart of the broker.
> At this point this is really caused by ARTEMIS-4193  and only affected 2.29.0 and no previous versions



--
This message was sent by Atlassian Jira
(v8.20.10#820010)