You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by "Bryan Turner (JIRA)" <ji...@apache.org> on 2010/05/09 06:22:48 UTC
[jira] Created: (SHIRO-156) SimpleAuthenticationInfo.merge does not
merge principals if its internal principal collection is not mutable
SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
------------------------------------------------------------------------------------------------------------
Key: SHIRO-156
URL: https://issues.apache.org/jira/browse/SHIRO-156
Project: Shiro
Issue Type: Bug
Components: Authentication (log-in)
Affects Versions: 0.9
Reporter: Bryan Turner
In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
{code}
if (this.principals == null) {
this.principals = info.getPrincipals();
} else {
if (this.principals instanceof MutablePrincipalCollection) {
((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
} else {
this.principals = new SimplePrincipalCollection(this.principals);
}
}
{code}
The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Les Hazlewood <lh...@apache.org>.
Also, I just noticed:
we have a <distributionManagement> section at the top of our root pom
that looks to match up with the comments in the Apache parent pom
(version 7). But there is also a 'release-profile' at the very bottom
of our root pom. Why do both exist?
Also, the version 7 parent pom defines the 'apache-release' profile -
how does this relate to the 'release-profile' at the bottom at the
file?
Thanks,
Les
On Fri, May 14, 2010 at 11:18 PM, Les Hazlewood <lh...@apache.org> wrote:
> On Fri, May 14, 2010 at 10:58 PM, Kalle Korhonen
> <ka...@gmail.com> wrote:
>>> should be code complete tonight! :)
>>
>> Quickly, before anybody opens more issues!
>
> Hahaha :)
>
>> Certainly. Run "mvn site-deploy" - need to have credentials set
>> correctly in your settings.xml (use your key). What are your groups on
>> people? Mine is:
>> [kaosko@minotaur:/www/incubator.apache.org/shiro]$ groups
>> kaosko committers
>
> [lhazlewood@minotaur:~]$ groups
> lhazlewood committers incubator
>
> When you say 'use your key' do you mean the PGP key in the KEYS file
> at the root of our SVN?
>
> Les
>
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Kalle Korhonen <ka...@gmail.com>.
Right, it takes a bit before they show up on the web site. Yeah we are
good to go there - Craig, the site's just for publishing the Maven
generated documentation, javadocs etc.
Kalle
On Sat, May 15, 2010 at 2:21 AM, Les Hazlewood <lh...@apache.org> wrote:
> I didn't deploy any artifacts that require voting - I was just testing
> to see if the Maven generated site would correctly publish to our
> incubator web space. It did publish correctly, but it's only the
> Maven generated site, and for a -SNAPSHOT only - not an actual
> release. Nothing else (.jars, source, etc) was published.
>
> Cheers,
>
> Les
>
> P.S. The pages are correctly showing up now - it seems as if it was a
> mirror sync kind of thing and nothing to worry about.
>
> On Sat, May 15, 2010 at 2:14 AM, Craig L Russell
> <cr...@oracle.com> wrote:
>> Where did you deploy your artifacts that we'll vote on?
>>
>> Craig
>>
>> On May 15, 2010, at 12:13 AM, Les Hazlewood wrote:
>>
>>> Hrm.
>>>
>>> It appears that there is a Confluence 'Site' page with a child of
>>> 'Banner':
>>>
>>> https://cwiki.apache.org/confluence/display/SHIRO/Site
>>>
>>> I think this might be screwing things up, but I don't know for sure
>>> what is going on.
>>>
>>> I'm still genuinely curious why the files we published don't show up
>>> though - maybe something having to do with mirroring?
>>>
>>> Les
>>>
>>> On Sat, May 15, 2010 at 12:08 AM, Les Hazlewood <lh...@apache.org>
>>> wrote:
>>>>
>>>> Ok, the 'mvn site-deploy' command appeared to complete without any
>>>> problem. But now I'm thoroughly confused:
>>>>
>>>> I'm logged in to people@ and I'm in the following directory:
>>>>
>>>> [lhazlewood@minotaur:/www/incubator.apache.org/shiro/site/latest]$ pwd
>>>> /www/incubator.apache.org/shiro/site/latest
>>>>
>>>> However, nothing comes up for this URL:
>>>>
>>>> http://incubator.apache.org/shiro/site/latest/index.html
>>>>
>>>> Directory/file permissions look good.
>>>>
>>>> Any idea why we can't see it?
>>>>
>>>> On Fri, May 14, 2010 at 11:58 PM, Les Hazlewood <lh...@apache.org>
>>>> wrote:
>>>>>
>>>>> Ahah - thanks. It has been a while since I've done a maven release (3
>>>>> months?) and I used password-based authentication at the time.
>>>>>
>>>>>> No, your own public/private SSH key pair, assuming you've created and
>>>>>> authorized one. Technically you can use password authentication as
>>>>>> well but then you'd need to put your password in the settings.xml. If
>>>>>> you are not familiar with mvn deploy & wagon, see
>>>>>> http://maven.apache.org/settings.html#Servers
>>>>>
>>>>> Ah, OK. I was reading this:
>>>>>
>>>>> http://maven.apache.org/developers/release/apache-release.html
>>>>>
>>>>> and noticed the 'gpg.passphrase' property (first preformatted block in
>>>>> that page). I set it to what I think is my passphrase and it is not
>>>>> working - it keeps asking me to type in my password :/
>>>>>
>>>>> But, I added my key to ~/.ssh/authorized_keys and all appears to be
>>>>> working now - thanks for the help!
>>>>>
>>>>>> And replying out-of-order to your follow-up question: the
>>>>>> release-profile is the default profile activated by release plugin if
>>>>>> useReleaseProfile is true (see
>>>>>> http://maven.apache.org/plugins/maven-release-plugin/). The profile is
>>>>>> there so we can deploy snapshot docs to constant location and release
>>>>>> docs to location specified by the version, compare the associated urls
>>>>>> in the respective distributionManagement sections.
>>>>>
>>>>> Gotcha, thanks.
>>>>>
>>>>> Les
>>>>>
>>>>
>>
>> Craig L Russell
>> Architect, Oracle
>> http://db.apache.org/jdo
>> 408 276-5638 mailto:Craig.Russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
>
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
Posted by Craig L Russell <cr...@oracle.com>.
Sorry, didn't read the mvn command closely enough. Site-deploy is a
different beast from what I thought you were up to.
Craig
On May 15, 2010, at 2:21 AM, Les Hazlewood wrote:
> I didn't deploy any artifacts that require voting - I was just testing
> to see if the Maven generated site would correctly publish to our
> incubator web space. It did publish correctly, but it's only the
> Maven generated site, and for a -SNAPSHOT only - not an actual
> release. Nothing else (.jars, source, etc) was published.
>
> Cheers,
>
> Les
>
> P.S. The pages are correctly showing up now - it seems as if it was a
> mirror sync kind of thing and nothing to worry about.
>
> On Sat, May 15, 2010 at 2:14 AM, Craig L Russell
> <cr...@oracle.com> wrote:
>> Where did you deploy your artifacts that we'll vote on?
>>
>> Craig
>>
>> On May 15, 2010, at 12:13 AM, Les Hazlewood wrote:
>>
>>> Hrm.
>>>
>>> It appears that there is a Confluence 'Site' page with a child of
>>> 'Banner':
>>>
>>> https://cwiki.apache.org/confluence/display/SHIRO/Site
>>>
>>> I think this might be screwing things up, but I don't know for sure
>>> what is going on.
>>>
>>> I'm still genuinely curious why the files we published don't show up
>>> though - maybe something having to do with mirroring?
>>>
>>> Les
>>>
>>> On Sat, May 15, 2010 at 12:08 AM, Les Hazlewood <lhazlewood@apache.org
>>> >
>>> wrote:
>>>>
>>>> Ok, the 'mvn site-deploy' command appeared to complete without any
>>>> problem. But now I'm thoroughly confused:
>>>>
>>>> I'm logged in to people@ and I'm in the following directory:
>>>>
>>>> [lhazlewood@minotaur:/www/incubator.apache.org/shiro/site/latest]
>>>> $ pwd
>>>> /www/incubator.apache.org/shiro/site/latest
>>>>
>>>> However, nothing comes up for this URL:
>>>>
>>>> http://incubator.apache.org/shiro/site/latest/index.html
>>>>
>>>> Directory/file permissions look good.
>>>>
>>>> Any idea why we can't see it?
>>>>
>>>> On Fri, May 14, 2010 at 11:58 PM, Les Hazlewood <lhazlewood@apache.org
>>>> >
>>>> wrote:
>>>>>
>>>>> Ahah - thanks. It has been a while since I've done a maven
>>>>> release (3
>>>>> months?) and I used password-based authentication at the time.
>>>>>
>>>>>> No, your own public/private SSH key pair, assuming you've
>>>>>> created and
>>>>>> authorized one. Technically you can use password authentication
>>>>>> as
>>>>>> well but then you'd need to put your password in the
>>>>>> settings.xml. If
>>>>>> you are not familiar with mvn deploy & wagon, see
>>>>>> http://maven.apache.org/settings.html#Servers
>>>>>
>>>>> Ah, OK. I was reading this:
>>>>>
>>>>> http://maven.apache.org/developers/release/apache-release.html
>>>>>
>>>>> and noticed the 'gpg.passphrase' property (first preformatted
>>>>> block in
>>>>> that page). I set it to what I think is my passphrase and it is
>>>>> not
>>>>> working - it keeps asking me to type in my password :/
>>>>>
>>>>> But, I added my key to ~/.ssh/authorized_keys and all appears to
>>>>> be
>>>>> working now - thanks for the help!
>>>>>
>>>>>> And replying out-of-order to your follow-up question: the
>>>>>> release-profile is the default profile activated by release
>>>>>> plugin if
>>>>>> useReleaseProfile is true (see
>>>>>> http://maven.apache.org/plugins/maven-release-plugin/). The
>>>>>> profile is
>>>>>> there so we can deploy snapshot docs to constant location and
>>>>>> release
>>>>>> docs to location specified by the version, compare the
>>>>>> associated urls
>>>>>> in the respective distributionManagement sections.
>>>>>
>>>>> Gotcha, thanks.
>>>>>
>>>>> Les
>>>>>
>>>>
>>
>> Craig L Russell
>> Architect, Oracle
>> http://db.apache.org/jdo
>> 408 276-5638 mailto:Craig.Russell@oracle.com
>> P.S. A good JDO? O, Gasp!
>>
>>
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Les Hazlewood <lh...@apache.org>.
I didn't deploy any artifacts that require voting - I was just testing
to see if the Maven generated site would correctly publish to our
incubator web space. It did publish correctly, but it's only the
Maven generated site, and for a -SNAPSHOT only - not an actual
release. Nothing else (.jars, source, etc) was published.
Cheers,
Les
P.S. The pages are correctly showing up now - it seems as if it was a
mirror sync kind of thing and nothing to worry about.
On Sat, May 15, 2010 at 2:14 AM, Craig L Russell
<cr...@oracle.com> wrote:
> Where did you deploy your artifacts that we'll vote on?
>
> Craig
>
> On May 15, 2010, at 12:13 AM, Les Hazlewood wrote:
>
>> Hrm.
>>
>> It appears that there is a Confluence 'Site' page with a child of
>> 'Banner':
>>
>> https://cwiki.apache.org/confluence/display/SHIRO/Site
>>
>> I think this might be screwing things up, but I don't know for sure
>> what is going on.
>>
>> I'm still genuinely curious why the files we published don't show up
>> though - maybe something having to do with mirroring?
>>
>> Les
>>
>> On Sat, May 15, 2010 at 12:08 AM, Les Hazlewood <lh...@apache.org>
>> wrote:
>>>
>>> Ok, the 'mvn site-deploy' command appeared to complete without any
>>> problem. But now I'm thoroughly confused:
>>>
>>> I'm logged in to people@ and I'm in the following directory:
>>>
>>> [lhazlewood@minotaur:/www/incubator.apache.org/shiro/site/latest]$ pwd
>>> /www/incubator.apache.org/shiro/site/latest
>>>
>>> However, nothing comes up for this URL:
>>>
>>> http://incubator.apache.org/shiro/site/latest/index.html
>>>
>>> Directory/file permissions look good.
>>>
>>> Any idea why we can't see it?
>>>
>>> On Fri, May 14, 2010 at 11:58 PM, Les Hazlewood <lh...@apache.org>
>>> wrote:
>>>>
>>>> Ahah - thanks. It has been a while since I've done a maven release (3
>>>> months?) and I used password-based authentication at the time.
>>>>
>>>>> No, your own public/private SSH key pair, assuming you've created and
>>>>> authorized one. Technically you can use password authentication as
>>>>> well but then you'd need to put your password in the settings.xml. If
>>>>> you are not familiar with mvn deploy & wagon, see
>>>>> http://maven.apache.org/settings.html#Servers
>>>>
>>>> Ah, OK. I was reading this:
>>>>
>>>> http://maven.apache.org/developers/release/apache-release.html
>>>>
>>>> and noticed the 'gpg.passphrase' property (first preformatted block in
>>>> that page). I set it to what I think is my passphrase and it is not
>>>> working - it keeps asking me to type in my password :/
>>>>
>>>> But, I added my key to ~/.ssh/authorized_keys and all appears to be
>>>> working now - thanks for the help!
>>>>
>>>>> And replying out-of-order to your follow-up question: the
>>>>> release-profile is the default profile activated by release plugin if
>>>>> useReleaseProfile is true (see
>>>>> http://maven.apache.org/plugins/maven-release-plugin/). The profile is
>>>>> there so we can deploy snapshot docs to constant location and release
>>>>> docs to location specified by the version, compare the associated urls
>>>>> in the respective distributionManagement sections.
>>>>
>>>> Gotcha, thanks.
>>>>
>>>> Les
>>>>
>>>
>
> Craig L Russell
> Architect, Oracle
> http://db.apache.org/jdo
> 408 276-5638 mailto:Craig.Russell@oracle.com
> P.S. A good JDO? O, Gasp!
>
>
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
Posted by Craig L Russell <cr...@oracle.com>.
Where did you deploy your artifacts that we'll vote on?
Craig
On May 15, 2010, at 12:13 AM, Les Hazlewood wrote:
> Hrm.
>
> It appears that there is a Confluence 'Site' page with a child of
> 'Banner':
>
> https://cwiki.apache.org/confluence/display/SHIRO/Site
>
> I think this might be screwing things up, but I don't know for sure
> what is going on.
>
> I'm still genuinely curious why the files we published don't show up
> though - maybe something having to do with mirroring?
>
> Les
>
> On Sat, May 15, 2010 at 12:08 AM, Les Hazlewood
> <lh...@apache.org> wrote:
>> Ok, the 'mvn site-deploy' command appeared to complete without any
>> problem. But now I'm thoroughly confused:
>>
>> I'm logged in to people@ and I'm in the following directory:
>>
>> [lhazlewood@minotaur:/www/incubator.apache.org/shiro/site/latest]$
>> pwd
>> /www/incubator.apache.org/shiro/site/latest
>>
>> However, nothing comes up for this URL:
>>
>> http://incubator.apache.org/shiro/site/latest/index.html
>>
>> Directory/file permissions look good.
>>
>> Any idea why we can't see it?
>>
>> On Fri, May 14, 2010 at 11:58 PM, Les Hazlewood <lhazlewood@apache.org
>> > wrote:
>>> Ahah - thanks. It has been a while since I've done a maven
>>> release (3
>>> months?) and I used password-based authentication at the time.
>>>
>>>> No, your own public/private SSH key pair, assuming you've created
>>>> and
>>>> authorized one. Technically you can use password authentication as
>>>> well but then you'd need to put your password in the
>>>> settings.xml. If
>>>> you are not familiar with mvn deploy & wagon, see
>>>> http://maven.apache.org/settings.html#Servers
>>>
>>> Ah, OK. I was reading this:
>>>
>>> http://maven.apache.org/developers/release/apache-release.html
>>>
>>> and noticed the 'gpg.passphrase' property (first preformatted
>>> block in
>>> that page). I set it to what I think is my passphrase and it is not
>>> working - it keeps asking me to type in my password :/
>>>
>>> But, I added my key to ~/.ssh/authorized_keys and all appears to be
>>> working now - thanks for the help!
>>>
>>>> And replying out-of-order to your follow-up question: the
>>>> release-profile is the default profile activated by release
>>>> plugin if
>>>> useReleaseProfile is true (see
>>>> http://maven.apache.org/plugins/maven-release-plugin/). The
>>>> profile is
>>>> there so we can deploy snapshot docs to constant location and
>>>> release
>>>> docs to location specified by the version, compare the associated
>>>> urls
>>>> in the respective distributionManagement sections.
>>>
>>> Gotcha, thanks.
>>>
>>> Les
>>>
>>
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
Posted by Craig L Russell <cr...@oracle.com>.
Hi Les,
For the release vote we shouldn't publish the artifacts on the public
web anyway. As long as they are available to committers we can start
the vote.
Craig
On May 15, 2010, at 12:13 AM, Les Hazlewood wrote:
> Hrm.
>
> It appears that there is a Confluence 'Site' page with a child of
> 'Banner':
>
> https://cwiki.apache.org/confluence/display/SHIRO/Site
>
> I think this might be screwing things up, but I don't know for sure
> what is going on.
>
> I'm still genuinely curious why the files we published don't show up
> though - maybe something having to do with mirroring?
>
> Les
>
> On Sat, May 15, 2010 at 12:08 AM, Les Hazlewood
> <lh...@apache.org> wrote:
>> Ok, the 'mvn site-deploy' command appeared to complete without any
>> problem. But now I'm thoroughly confused:
>>
>> I'm logged in to people@ and I'm in the following directory:
>>
>> [lhazlewood@minotaur:/www/incubator.apache.org/shiro/site/latest]$
>> pwd
>> /www/incubator.apache.org/shiro/site/latest
>>
>> However, nothing comes up for this URL:
>>
>> http://incubator.apache.org/shiro/site/latest/index.html
>>
>> Directory/file permissions look good.
>>
>> Any idea why we can't see it?
>>
>> On Fri, May 14, 2010 at 11:58 PM, Les Hazlewood <lhazlewood@apache.org
>> > wrote:
>>> Ahah - thanks. It has been a while since I've done a maven
>>> release (3
>>> months?) and I used password-based authentication at the time.
>>>
>>>> No, your own public/private SSH key pair, assuming you've created
>>>> and
>>>> authorized one. Technically you can use password authentication as
>>>> well but then you'd need to put your password in the
>>>> settings.xml. If
>>>> you are not familiar with mvn deploy & wagon, see
>>>> http://maven.apache.org/settings.html#Servers
>>>
>>> Ah, OK. I was reading this:
>>>
>>> http://maven.apache.org/developers/release/apache-release.html
>>>
>>> and noticed the 'gpg.passphrase' property (first preformatted
>>> block in
>>> that page). I set it to what I think is my passphrase and it is not
>>> working - it keeps asking me to type in my password :/
>>>
>>> But, I added my key to ~/.ssh/authorized_keys and all appears to be
>>> working now - thanks for the help!
>>>
>>>> And replying out-of-order to your follow-up question: the
>>>> release-profile is the default profile activated by release
>>>> plugin if
>>>> useReleaseProfile is true (see
>>>> http://maven.apache.org/plugins/maven-release-plugin/). The
>>>> profile is
>>>> there so we can deploy snapshot docs to constant location and
>>>> release
>>>> docs to location specified by the version, compare the associated
>>>> urls
>>>> in the respective distributionManagement sections.
>>>
>>> Gotcha, thanks.
>>>
>>> Les
>>>
>>
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:Craig.Russell@oracle.com
P.S. A good JDO? O, Gasp!
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Les Hazlewood <lh...@apache.org>.
Hrm.
It appears that there is a Confluence 'Site' page with a child of 'Banner':
https://cwiki.apache.org/confluence/display/SHIRO/Site
I think this might be screwing things up, but I don't know for sure
what is going on.
I'm still genuinely curious why the files we published don't show up
though - maybe something having to do with mirroring?
Les
On Sat, May 15, 2010 at 12:08 AM, Les Hazlewood <lh...@apache.org> wrote:
> Ok, the 'mvn site-deploy' command appeared to complete without any
> problem. But now I'm thoroughly confused:
>
> I'm logged in to people@ and I'm in the following directory:
>
> [lhazlewood@minotaur:/www/incubator.apache.org/shiro/site/latest]$ pwd
> /www/incubator.apache.org/shiro/site/latest
>
> However, nothing comes up for this URL:
>
> http://incubator.apache.org/shiro/site/latest/index.html
>
> Directory/file permissions look good.
>
> Any idea why we can't see it?
>
> On Fri, May 14, 2010 at 11:58 PM, Les Hazlewood <lh...@apache.org> wrote:
>> Ahah - thanks. It has been a while since I've done a maven release (3
>> months?) and I used password-based authentication at the time.
>>
>>> No, your own public/private SSH key pair, assuming you've created and
>>> authorized one. Technically you can use password authentication as
>>> well but then you'd need to put your password in the settings.xml. If
>>> you are not familiar with mvn deploy & wagon, see
>>> http://maven.apache.org/settings.html#Servers
>>
>> Ah, OK. I was reading this:
>>
>> http://maven.apache.org/developers/release/apache-release.html
>>
>> and noticed the 'gpg.passphrase' property (first preformatted block in
>> that page). I set it to what I think is my passphrase and it is not
>> working - it keeps asking me to type in my password :/
>>
>> But, I added my key to ~/.ssh/authorized_keys and all appears to be
>> working now - thanks for the help!
>>
>>> And replying out-of-order to your follow-up question: the
>>> release-profile is the default profile activated by release plugin if
>>> useReleaseProfile is true (see
>>> http://maven.apache.org/plugins/maven-release-plugin/). The profile is
>>> there so we can deploy snapshot docs to constant location and release
>>> docs to location specified by the version, compare the associated urls
>>> in the respective distributionManagement sections.
>>
>> Gotcha, thanks.
>>
>> Les
>>
>
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Les Hazlewood <lh...@apache.org>.
Ok, the 'mvn site-deploy' command appeared to complete without any
problem. But now I'm thoroughly confused:
I'm logged in to people@ and I'm in the following directory:
[lhazlewood@minotaur:/www/incubator.apache.org/shiro/site/latest]$ pwd
/www/incubator.apache.org/shiro/site/latest
However, nothing comes up for this URL:
http://incubator.apache.org/shiro/site/latest/index.html
Directory/file permissions look good.
Any idea why we can't see it?
On Fri, May 14, 2010 at 11:58 PM, Les Hazlewood <lh...@apache.org> wrote:
> Ahah - thanks. It has been a while since I've done a maven release (3
> months?) and I used password-based authentication at the time.
>
>> No, your own public/private SSH key pair, assuming you've created and
>> authorized one. Technically you can use password authentication as
>> well but then you'd need to put your password in the settings.xml. If
>> you are not familiar with mvn deploy & wagon, see
>> http://maven.apache.org/settings.html#Servers
>
> Ah, OK. I was reading this:
>
> http://maven.apache.org/developers/release/apache-release.html
>
> and noticed the 'gpg.passphrase' property (first preformatted block in
> that page). I set it to what I think is my passphrase and it is not
> working - it keeps asking me to type in my password :/
>
> But, I added my key to ~/.ssh/authorized_keys and all appears to be
> working now - thanks for the help!
>
>> And replying out-of-order to your follow-up question: the
>> release-profile is the default profile activated by release plugin if
>> useReleaseProfile is true (see
>> http://maven.apache.org/plugins/maven-release-plugin/). The profile is
>> there so we can deploy snapshot docs to constant location and release
>> docs to location specified by the version, compare the associated urls
>> in the respective distributionManagement sections.
>
> Gotcha, thanks.
>
> Les
>
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Les Hazlewood <lh...@apache.org>.
Ahah - thanks. It has been a while since I've done a maven release (3
months?) and I used password-based authentication at the time.
> No, your own public/private SSH key pair, assuming you've created and
> authorized one. Technically you can use password authentication as
> well but then you'd need to put your password in the settings.xml. If
> you are not familiar with mvn deploy & wagon, see
> http://maven.apache.org/settings.html#Servers
Ah, OK. I was reading this:
http://maven.apache.org/developers/release/apache-release.html
and noticed the 'gpg.passphrase' property (first preformatted block in
that page). I set it to what I think is my passphrase and it is not
working - it keeps asking me to type in my password :/
But, I added my key to ~/.ssh/authorized_keys and all appears to be
working now - thanks for the help!
> And replying out-of-order to your follow-up question: the
> release-profile is the default profile activated by release plugin if
> useReleaseProfile is true (see
> http://maven.apache.org/plugins/maven-release-plugin/). The profile is
> there so we can deploy snapshot docs to constant location and release
> docs to location specified by the version, compare the associated urls
> in the respective distributionManagement sections.
Gotcha, thanks.
Les
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Kalle Korhonen <ka...@gmail.com>.
On Fri, May 14, 2010 at 11:18 PM, Les Hazlewood <lh...@apache.org> wrote:
>> Certainly. Run "mvn site-deploy" - need to have credentials set
>> correctly in your settings.xml (use your key). What are your groups on
>> people? Mine is:
>> [kaosko@minotaur:/www/incubator.apache.org/shiro]$ groups
>> kaosko committers
> [lhazlewood@minotaur:~]$ groups
> lhazlewood committers incubator
I knew it - I'm missing the incubator group, now I just need to find
somebody who can add me back to that group.
> When you say 'use your key' do you mean the PGP key in the KEYS file
> at the root of our SVN?
No, your own public/private SSH key pair, assuming you've created and
authorized one. Technically you can use password authentication as
well but then you'd need to put your password in the settings.xml. If
you are not familiar with mvn deploy & wagon, see
http://maven.apache.org/settings.html#Servers
And replying out-of-order to your follow-up question: the
release-profile is the default profile activated by release plugin if
useReleaseProfile is true (see
http://maven.apache.org/plugins/maven-release-plugin/). The profile is
there so we can deploy snapshot docs to constant location and release
docs to location specified by the version, compare the associated urls
in the respective distributionManagement sections.
Kalle
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Les Hazlewood <lh...@apache.org>.
On Fri, May 14, 2010 at 10:58 PM, Kalle Korhonen
<ka...@gmail.com> wrote:
>> should be code complete tonight! :)
>
> Quickly, before anybody opens more issues!
Hahaha :)
> Certainly. Run "mvn site-deploy" - need to have credentials set
> correctly in your settings.xml (use your key). What are your groups on
> people? Mine is:
> [kaosko@minotaur:/www/incubator.apache.org/shiro]$ groups
> kaosko committers
[lhazlewood@minotaur:~]$ groups
lhazlewood committers incubator
When you say 'use your key' do you mean the PGP key in the KEYS file
at the root of our SVN?
Les
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Kalle Korhonen <ka...@gmail.com>.
On Fri, May 14, 2010 at 10:48 PM, Les Hazlewood <lh...@apache.org> wrote:
> I'm about to commit my 'remove deprecated...' issue. That means we
> should be code complete tonight! :)
Quickly, before anybody opens more issues!
> Let me ask you a question. Is there a way that I can test publishing
> the site since I should have access to create the directory - just to
> test it out? It'd be nice to close out that final issue so we have no
> outstanding issues at all going into the voting process.
Certainly. Run "mvn site-deploy" - need to have credentials set
correctly in your settings.xml (use your key). What are your groups on
people? Mine is:
[kaosko@minotaur:/www/incubator.apache.org/shiro]$ groups
kaosko committers
Kalle
> On Fri, May 14, 2010 at 10:45 PM, Kalle Korhonen (JIRA) <ji...@apache.org> wrote:
>>
>> [ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Kalle Korhonen resolved SHIRO-156.
>> ----------------------------------
>>
>> Resolution: Fixed
>>
>>> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
>>> ------------------------------------------------------------------------------------------------------------
>>>
>>> Key: SHIRO-156
>>> URL: https://issues.apache.org/jira/browse/SHIRO-156
>>> Project: Shiro
>>> Issue Type: Bug
>>> Components: Authentication (log-in)
>>> Affects Versions: 0.9
>>> Reporter: Bryan Turner
>>> Assignee: Kalle Korhonen
>>> Fix For: 1.0.0
>>>
>>>
>>> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
>>> {code}
>>> if (this.principals == null) {
>>> this.principals = info.getPrincipals();
>>> } else {
>>> if (this.principals instanceof MutablePrincipalCollection) {
>>> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
>>> } else {
>>> this.principals = new SimplePrincipalCollection(this.principals);
>>> }
>>> }
>>> {code}
>>> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Re: [jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by Les Hazlewood <lh...@apache.org>.
Thanks Kalle!
I'm about to commit my 'remove deprecated...' issue. That means we
should be code complete tonight! :)
Let me ask you a question. Is there a way that I can test publishing
the site since I should have access to create the directory - just to
test it out? It'd be nice to close out that final issue so we have no
outstanding issues at all going into the voting process.
Les
On Fri, May 14, 2010 at 10:45 PM, Kalle Korhonen (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Kalle Korhonen resolved SHIRO-156.
> ----------------------------------
>
> Resolution: Fixed
>
>> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
>> ------------------------------------------------------------------------------------------------------------
>>
>> Key: SHIRO-156
>> URL: https://issues.apache.org/jira/browse/SHIRO-156
>> Project: Shiro
>> Issue Type: Bug
>> Components: Authentication (log-in)
>> Affects Versions: 0.9
>> Reporter: Bryan Turner
>> Assignee: Kalle Korhonen
>> Fix For: 1.0.0
>>
>>
>> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
>> {code}
>> if (this.principals == null) {
>> this.principals = info.getPrincipals();
>> } else {
>> if (this.principals instanceof MutablePrincipalCollection) {
>> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
>> } else {
>> this.principals = new SimplePrincipalCollection(this.principals);
>> }
>> }
>> {code}
>> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Updated: (SHIRO-156) SimpleAuthenticationInfo.merge does not
merge principals if its internal principal collection is not mutable
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Les Hazlewood updated SHIRO-156:
--------------------------------
Fix Version/s: 1.0.0
Scheduling for 1.0 since this will be easy to fix
> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-156
> URL: https://issues.apache.org/jira/browse/SHIRO-156
> Project: Shiro
> Issue Type: Bug
> Components: Authentication (log-in)
> Affects Versions: 0.9
> Reporter: Bryan Turner
> Fix For: 1.0.0
>
>
> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
> {code}
> if (this.principals == null) {
> this.principals = info.getPrincipals();
> } else {
> if (this.principals instanceof MutablePrincipalCollection) {
> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
> } else {
> this.principals = new SimplePrincipalCollection(this.principals);
> }
> }
> {code}
> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867562#action_12867562 ]
Kalle Korhonen commented on SHIRO-156:
--------------------------------------
The suggested change does what is intended, but is this the right thing to do? I mean, if the the collection is meant as immutable, shouldn't merge just throw an exception rather than make it mutable?
> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-156
> URL: https://issues.apache.org/jira/browse/SHIRO-156
> Project: Shiro
> Issue Type: Bug
> Components: Authentication (log-in)
> Affects Versions: 0.9
> Reporter: Bryan Turner
> Assignee: Kalle Korhonen
> Fix For: 1.0.0
>
>
> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
> {code}
> if (this.principals == null) {
> this.principals = info.getPrincipals();
> } else {
> if (this.principals instanceof MutablePrincipalCollection) {
> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
> } else {
> this.principals = new SimplePrincipalCollection(this.principals);
> }
> }
> {code}
> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865551#action_12865551 ]
Kalle Korhonen commented on SHIRO-156:
--------------------------------------
I'll throw in a unit test for good measure as well.
> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-156
> URL: https://issues.apache.org/jira/browse/SHIRO-156
> Project: Shiro
> Issue Type: Bug
> Components: Authentication (log-in)
> Affects Versions: 0.9
> Reporter: Bryan Turner
> Assignee: Kalle Korhonen
> Fix For: 1.0.0
>
>
> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
> {code}
> if (this.principals == null) {
> this.principals = info.getPrincipals();
> } else {
> if (this.principals instanceof MutablePrincipalCollection) {
> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
> } else {
> this.principals = new SimplePrincipalCollection(this.principals);
> }
> }
> {code}
> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen reassigned SHIRO-156:
------------------------------------
Assignee: Kalle Korhonen
> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-156
> URL: https://issues.apache.org/jira/browse/SHIRO-156
> Project: Shiro
> Issue Type: Bug
> Components: Authentication (log-in)
> Affects Versions: 0.9
> Reporter: Bryan Turner
> Assignee: Kalle Korhonen
> Fix For: 1.0.0
>
>
> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
> {code}
> if (this.principals == null) {
> this.principals = info.getPrincipals();
> } else {
> if (this.principals instanceof MutablePrincipalCollection) {
> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
> } else {
> this.principals = new SimplePrincipalCollection(this.principals);
> }
> }
> {code}
> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867765#action_12867765 ]
Les Hazlewood commented on SHIRO-156:
-------------------------------------
I think it's ok that the new PrincipalCollection is mutable - it is really there as an aggregation construct to pull in data from all realms, and to just add to what might exist already. If we wanted to create a new immutable PrincipalCollection every time, that would be OK too (and probably a little safer). We just don't have an immutable PrincipalCollection implementation at the moment.
> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-156
> URL: https://issues.apache.org/jira/browse/SHIRO-156
> Project: Shiro
> Issue Type: Bug
> Components: Authentication (log-in)
> Affects Versions: 0.9
> Reporter: Bryan Turner
> Assignee: Kalle Korhonen
> Fix For: 1.0.0
>
>
> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
> {code}
> if (this.principals == null) {
> this.principals = info.getPrincipals();
> } else {
> if (this.principals instanceof MutablePrincipalCollection) {
> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
> } else {
> this.principals = new SimplePrincipalCollection(this.principals);
> }
> }
> {code}
> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by "Bryan Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865534#action_12865534 ]
Bryan Turner commented on SHIRO-156:
------------------------------------
I believe the logic should look like this:
{code}
if (this.principals == null) {
this.principals = info.getPrincipals();
} else {
if (!(this.principals instanceof MutablePrincipalCollection)) {
this.principals = new SimplePrincipalCollection(this.principals);
}
((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
}
{code}
This will transform the internal principal collection into a mutable one if necessary and will always merge info.getPrincipals() into it.
> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-156
> URL: https://issues.apache.org/jira/browse/SHIRO-156
> Project: Shiro
> Issue Type: Bug
> Components: Authentication (log-in)
> Affects Versions: 0.9
> Reporter: Bryan Turner
>
> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
> {code}
> if (this.principals == null) {
> this.principals = info.getPrincipals();
> } else {
> if (this.principals instanceof MutablePrincipalCollection) {
> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
> } else {
> this.principals = new SimplePrincipalCollection(this.principals);
> }
> }
> {code}
> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHIRO-156) SimpleAuthenticationInfo.merge does
not merge principals if its internal principal collection is not mutable
Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHIRO-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kalle Korhonen resolved SHIRO-156.
----------------------------------
Resolution: Fixed
> SimpleAuthenticationInfo.merge does not merge principals if its internal principal collection is not mutable
> ------------------------------------------------------------------------------------------------------------
>
> Key: SHIRO-156
> URL: https://issues.apache.org/jira/browse/SHIRO-156
> Project: Shiro
> Issue Type: Bug
> Components: Authentication (log-in)
> Affects Versions: 0.9
> Reporter: Bryan Turner
> Assignee: Kalle Korhonen
> Fix For: 1.0.0
>
>
> In SimpleAuthenticationInfo.merge(AuthenticationInfo), there is the following code:
> {code}
> if (this.principals == null) {
> this.principals = info.getPrincipals();
> } else {
> if (this.principals instanceof MutablePrincipalCollection) {
> ((MutablePrincipalCollection) this.principals).addAll(info.getPrincipals());
> } else {
> this.principals = new SimplePrincipalCollection(this.principals);
> }
> }
> {code}
> The logic in the nested else block appears incorrect. If the current "principals" collection is not MutablePrincipalCollection, a new SimplePrincipalCollection, which is mutable, is constructed from it. However, it does not copy the principals from other.getPrincipals(), which by that point in the method is known to be non-null and non-empty, after it makes a mutable principal collection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.