You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ch...@apache.org on 2024/10/01 09:34:07 UTC
(lucene) branch main updated: Override iterator in Empty off heap vector values (#13837)
This is an automated email from the ASF dual-hosted git repository.
chegar pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git
The following commit(s) were added to refs/heads/main by this push:
new cce7d36920d Override iterator in Empty off heap vector values (#13837)
cce7d36920d is described below
commit cce7d36920dcdae87110da9127e5b9f9d1a7644b
Author: Chris Hegarty <62...@users.noreply.github.com>
AuthorDate: Tue Oct 1 10:32:38 2024 +0100
Override iterator in Empty off heap vector values (#13837)
This commit override the iterator method in the empty off-heap vector values. The implementation is just the dense iterator, which handles empty values just fine. We use it elsewhere for similar too.
---
.../lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java | 5 +++++
.../lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java | 5 +++++
.../lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java | 5 +++++
3 files changed, 15 insertions(+)
diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java
index c53594f36a4..7c87bac5e54 100644
--- a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java
+++ b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/OffHeapFloatVectorValues.java
@@ -249,6 +249,11 @@ abstract class OffHeapFloatVectorValues extends FloatVectorValues {
throw new UnsupportedOperationException();
}
+ @Override
+ public DocIndexIterator iterator() {
+ return createDenseIterator();
+ }
+
@Override
public Bits getAcceptOrds(Bits acceptDocs) {
return null;
diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java
index aedda7a6258..0c428bb169f 100644
--- a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java
+++ b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapByteVectorValues.java
@@ -263,6 +263,11 @@ abstract class OffHeapByteVectorValues extends ByteVectorValues {
throw new UnsupportedOperationException();
}
+ @Override
+ public DocIndexIterator iterator() {
+ return createDenseIterator();
+ }
+
@Override
public Bits getAcceptOrds(Bits acceptDocs) {
return null;
diff --git a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java
index 02664837982..b21df901ddb 100644
--- a/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java
+++ b/lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/OffHeapFloatVectorValues.java
@@ -262,6 +262,11 @@ abstract class OffHeapFloatVectorValues extends FloatVectorValues {
throw new UnsupportedOperationException();
}
+ @Override
+ public DocIndexIterator iterator() {
+ return createDenseIterator();
+ }
+
@Override
public Bits getAcceptOrds(Bits acceptDocs) {
return null;