You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ga...@apache.org on 2008/05/07 17:00:56 UTC

svn commit: r654134 - /geronimo/server/trunk/buildsupport/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/DeployModuleMojo.java

Author: gawor
Date: Wed May  7 08:00:55 2008
New Revision: 654134

URL: http://svn.apache.org/viewvc?rev=654134&view=rev
Log:
nicer logging when no plan is specified (GERONIMO-3848)

Modified:
    geronimo/server/trunk/buildsupport/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/DeployModuleMojo.java

Modified: geronimo/server/trunk/buildsupport/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/DeployModuleMojo.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/buildsupport/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/DeployModuleMojo.java?rev=654134&r1=654133&r2=654134&view=diff
==============================================================================
--- geronimo/server/trunk/buildsupport/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/DeployModuleMojo.java (original)
+++ geronimo/server/trunk/buildsupport/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/DeployModuleMojo.java Wed May  7 08:00:55 2008
@@ -78,7 +78,9 @@
 
         if (moduleArchive != null || modulePlan != null) {
             log.info("Using non-artifact based module archive: " + moduleArchive);
-            log.info("Using non-artifact based plan: " + modulePlan);
+            if (modulePlan != null) {
+                log.info("Using non-artifact based plan: " + modulePlan);
+            }
 
             TargetModuleID[] ids = distribute(moduleArchive, modulePlan);
             completed.add(ids);
@@ -143,7 +145,13 @@
     }
 
     private TargetModuleID[] distribute(final File file, final File plan) throws Exception {
-        log.info("Distributing module artifact: " + file + " with plan " + plan);
+        if (log.isInfoEnabled()) {
+            String msg = "Distributing module artifact: " + file;
+            if (plan != null) {
+                msg += " with plan " + plan;
+            }
+            log.info(msg);
+        }
 
         DeploymentManager manager = getDeploymentManager();
         Target[] targets = manager.getTargets();