[GitHub] [cloudstack] lujiefsi commented on a change in pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir and fixed an NPE

[GitBox <gi...@apache.org>]

lujiefsi commented on a change in pull request #5066:
URL: https://github.com/apache/cloudstack/pull/5066#discussion_r662764683



##########
File path: core/src/main/java/com/cloud/storage/JavaStorageLayer.java
##########
@@ -178,18 +183,25 @@ public long getSize(String path) {
     }
 
     @Override
-    public File createUniqDir() {
+    public File createUniqDir() throws IOException {
         String dirName = System.getProperty("java.io.tmpdir");
         if (dirName != null) {
             File dir = new File(dirName);
             if (dir.exists()) {
+                if (isWorldReadable(dir)) {
+                    if (dir.getAbsolutePath().equals("/tmp")) {

Review comment:
       /tmp is the default tmp dir for linux. if we directly tell the user "temp dir is is World Readable", we may mislead user to change the permission of "/tmp", which is not desirable. So we just tell user "the temp dir is /tmp" and hope they change the default temp dir.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org