You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2015/05/09 23:01:30 UTC

svn commit: r1678525 - in /webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob: MemoryBlobTest.java OverflowBlobTest.java WritableBlobTestBase.java

Author: veithen
Date: Sat May  9 21:01:30 2015
New Revision: 1678525

URL: http://svn.apache.org/r1678525
Log:
Simplify blob test cases.

Modified:
    webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/MemoryBlobTest.java
    webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/OverflowBlobTest.java
    webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/WritableBlobTestBase.java

Modified: webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/MemoryBlobTest.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/MemoryBlobTest.java?rev=1678525&r1=1678524&r2=1678525&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/MemoryBlobTest.java (original)
+++ webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/MemoryBlobTest.java Sat May  9 21:01:30 2015
@@ -23,8 +23,4 @@ public class MemoryBlobTest extends Writ
     protected WritableBlob createBlob() {
         return new MemoryBlob();
     }
-
-    protected void releaseBlob(WritableBlob blob) {
-        // Nothing to do here
-    }
 }

Modified: webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/OverflowBlobTest.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/OverflowBlobTest.java?rev=1678525&r1=1678524&r2=1678525&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/OverflowBlobTest.java (original)
+++ webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/OverflowBlobTest.java Sat May  9 21:01:30 2015
@@ -23,8 +23,4 @@ public class OverflowBlobTest extends Wr
     protected WritableBlob createBlob() {
         return new OverflowBlob(16, 1024, "test", ".dat");
     }
-
-    protected void releaseBlob(WritableBlob blob) {
-        ((OverflowBlob)blob).release();
-    }
 }

Modified: webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/WritableBlobTestBase.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/WritableBlobTestBase.java?rev=1678525&r1=1678524&r2=1678525&view=diff
==============================================================================
--- webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/WritableBlobTestBase.java (original)
+++ webservices/axiom/trunk/modules/axiom-api/src/test/java/org/apache/axiom/util/blob/WritableBlobTestBase.java Sat May  9 21:01:30 2015
@@ -35,7 +35,6 @@ public abstract class WritableBlobTestBa
     private final static Random random = new Random();
     
     protected abstract WritableBlob createBlob();
-    protected abstract void releaseBlob(WritableBlob blob);
     
     private void doTestRandomReadWrite(int size) throws IOException {
         byte[] data = new byte[size];
@@ -74,7 +73,7 @@ public abstract class WritableBlobTestBa
             assertTrue(Arrays.equals(data, data2));
         }
         finally {
-            releaseBlob(blob);
+            blob.release();
         }
     }
     
@@ -108,7 +107,7 @@ public abstract class WritableBlobTestBa
             assertTrue(Arrays.equals(sourceData1, data1));
             assertTrue(Arrays.equals(sourceData2, data2));
         } finally {
-            releaseBlob(blob);
+            blob.release();
         }
     }
     
@@ -127,7 +126,7 @@ public abstract class WritableBlobTestBa
             }
         }
         finally {
-            releaseBlob(blob);
+            blob.release();
         }
     }
     
@@ -154,7 +153,7 @@ public abstract class WritableBlobTestBa
                 out.close();
             }
         } finally {
-            releaseBlob(blob);
+            blob.release();
         }
     }
     
@@ -170,7 +169,7 @@ public abstract class WritableBlobTestBa
                 // Expected
             }
         } finally {
-            releaseBlob(blob);
+            blob.release();
         }
     }
     
@@ -203,7 +202,7 @@ public abstract class WritableBlobTestBa
                 }
             }
         } finally {
-            releaseBlob(blob);
+            blob.release();
         }
     }
     
@@ -234,7 +233,7 @@ public abstract class WritableBlobTestBa
                 out.close();
             }
         } finally {
-            releaseBlob(blob);
+            blob.release();
         }
     }
 }