You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/23 08:25:46 UTC

[GitHub] [pulsar] BewareMyPower commented on pull request #14260: Fix PersistentAcknowledgmentsGroupingTracker set BitSet issue.

BewareMyPower commented on PR #14260:
URL: https://github.com/apache/pulsar/pull/14260#issuecomment-1363730145

   > > So I have added getOriginalBatchSize to return the user-specified batch size.
   > 
   > @Technoboy- what does the "user-specified batch size" mean? I'd assume that each batch message has a batch size of what the actual batch size for that message is?
   
   @lhotari Actually the new `getOriginalBatchSize()` is confusing. The `getBatchSize()` should not retrieve the batch size from the `BatchMessageAcker` because the acker could be a `BatchMessageAckerDisabled` whose batch size field is 0. I removed this confusing method and fix the `getBatchSize()` method in https://github.com/apache/pulsar/pull/19031.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org