You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2026/07/16 21:14:44 UTC
Re: [PR] chore: fix `SlidingDistinctCountAccumulator::size()` to include budget for distinct values [datafusion]
codecov-commenter commented on PR #23399:
URL: https://github.com/apache/datafusion/pull/23399#issuecomment-4996655074
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/23399?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.65%. Comparing base ([`e104138`](https://app.codecov.io/gh/apache/datafusion/commit/e104138b4d45d3acfb76223cd968385f6764477b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`45e2b83`](https://app.codecov.io/gh/apache/datafusion/commit/45e2b835a6e33cc9317d71937e25ed4decfdc679?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/23399?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [datafusion/functions-aggregate/src/count.rs](https://app.codecov.io/gh/apache/datafusion/pull/23399?src=pr&el=tree&filepath=datafusion%2Ffunctions-aggregate%2Fsrc%2Fcount.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9mdW5jdGlvbnMtYWdncmVnYXRlL3NyYy9jb3VudC5ycw==) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #23399 +/- ##
=======================================
Coverage 80.65% 80.65%
=======================================
Files 1086 1086
Lines 366521 366529 +8
Branches 366521 366529 +8
=======================================
+ Hits 295618 295626 +8
- Misses 53274 53277 +3
+ Partials 17629 17626 -3
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/23399?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org