[GitHub] [arrow] jpedroantunes commented on a change in pull request #9906: ARROW-12229: [C++][Gandiva] Implement IS_DATE([string]) function

[GitBox <gi...@apache.org>]

jpedroantunes commented on a change in pull request #9906:
URL: https://github.com/apache/arrow/pull/9906#discussion_r609573756



##########
File path: cpp/src/gandiva/gdv_function_stubs.h
##########
@@ -39,11 +39,14 @@ uint8_t* gdv_fn_context_arena_malloc(int64_t context_ptr, int32_t data_len);
 
 void gdv_fn_context_arena_reset(int64_t context_ptr);
 
-bool in_expr_lookup_int32(int64_t ptr, int32_t value, bool in_validity);
+bool gdv_fn_in_expr_lookup_int32(int64_t ptr, int32_t value, bool in_validity);

Review comment:
       I just removed these corrections.
   I noticed that these functions definitions on header are incorrect defined compared to their implementation on the gdv_functions_stubs.cc, so I just corrected them here. But it seems fine to put this on a separate PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org