You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/22 13:38:38 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4551: Fix
license headers and rename E2E job name
kezhenxu94 opened a new pull request #4551: Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4551: [Chore]
Fix license headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602235251
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=h1) Report
> Merging [#4551](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/259a147682e82c862f5d4af90237e099b6d38b13&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4551 +/- ##
=======================================
Coverage 25.54% 25.54%
=======================================
Files 1246 1246
Lines 28975 28975
Branches 3974 3974
=======================================
Hits 7403 7403
Misses 20880 20880
Partials 692 692
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=footer). Last update [259a147...c60587c](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4551: [Chore] Fix license
headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602299374
I don't see the failing and the what are the changes related to the rat. Do you push those?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4551: [Chore] Fix
license headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602206107
> Do e2e tests have been checked by rat?
If the rat is only for checking license headers, then the checkstyle plugin has already done this, if the rat has other functionalities, I could add it to e2e project too
https://github.com/apache/skywalking/blob/ace781ff490310de09313f19194281826f9064b0/test/e2e/pom.xml#L145
https://github.com/apache/skywalking/blob/master/apm-checkstyle/CHECKSTYLE_HEAD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4551: [Chore] Fix
license headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602229492
> I am thinking `rat` is not set right.
Yes it's not working, after fixing the plugin's configuration itself, the checks failed to pass, but I don't have much time to inspect how the plugin actually work(seems regexp matching), yet the license headers are now checked by the CheckStyle plugin, so we can safely believe that the license headers did not conflict with the ASF
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4551: [Chore] Fix license
headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602212297
I am thinking `rat` is not set right. You could run this test, change any file in the source folder(not e2e) the header to `Licensed to the acs under one or more` at the first line, run check. You could see this
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.188 s
[INFO] Finished at: 2020-03-22T22:28:53+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project apm-datacarrier: You have 1 Checkstyle violation. -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4551: [Chore]
Fix license headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602235251
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=h1) Report
> Merging [#4551](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e509f6734106919542ec823b92a09dc491c70cd6&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4551 +/- ##
==========================================
- Coverage 25.57% 25.54% -0.03%
==========================================
Files 1246 1246
Lines 28975 28975
Branches 3974 3974
==========================================
- Hits 7410 7403 -7
- Misses 20873 20880 +7
Partials 692 692
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4551/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=footer). Last update [259a147...162ecb4](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4551: [Chore] Fix
license headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4551: [Chore] Fix license
headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602231584
It is mainly for header and dependency lib license chekck.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4551: [Chore] Fix
license headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602232493
Then I may need some time to find out why it failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4551: [Chore] Fix
license headers and rename E2E job name
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4551: [Chore] Fix license headers and rename E2E job name
URL: https://github.com/apache/skywalking/pull/4551#issuecomment-602235251
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=h1) Report
> Merging [#4551](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/ace781ff490310de09313f19194281826f9064b0?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4551 +/- ##
==========================================
- Coverage 25.57% 25.57% -0.01%
==========================================
Files 1246 1246
Lines 28975 28975
Branches 3974 3974
==========================================
- Hits 7410 7409 -1
Misses 20873 20873
- Partials 692 693 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/4551/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `24.73% <0%> (-1.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=footer). Last update [ace781f...147d808](https://codecov.io/gh/apache/skywalking/pull/4551?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services