You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/17 06:24:08 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Donny9 opened a new pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318
## Summary
Support l3gd20 sensor with new sensor model on stm32f429i-discovery board.
## Impact
We can test l3gd20 gyroscope sensor on stm32f429i-discovery board.
## Testing
daily test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729523664
> Also, why the need to introduce a config variable for the gyro which is actually on-board? I would presume this should always be zero (many boards do this).
okay, i revert this commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d edited a comment on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
v01d edited a comment on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-730367365
I think the placement is OK
EDIT: I was answering @xiaoxiang781216 comment which I received by email, but don't know why it does not appear here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-730367365
I think the placement is OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-730115472
Actually I requested for the check for HPWORK to be moved to Kconfig, but maybe I wasn't clear. I imagine you can select HPWORK if buffer size > 0. This avoids trial and error building.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-730800579
> I think the placement is OK
> EDIT: I was answering @xiaoxiang781216 comment which I received by email, but don't know why it does not appear here
I talk with @Donny9 privately and he has tried put the select in SENSORS_L3GD20_BUFFER_SIZE, but kconfig-frontend don't accept that if expression contain self.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729103233
Also, why the need to introduce a config variable for the gyro which is actually on-board? I would presume this should always be zero (many boards do this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#discussion_r526659008
##########
File path: drivers/sensors/Kconfig
##########
@@ -222,9 +222,19 @@ config SENSORS_L3GD20
bool "STMicro L3GD20 Gyroscope Sensor support"
default n
select SPI
+ select SCHED_HPWORK if SENSORS_L3GD20_BUFFER_SIZE > 0
Review comment:
should we move to SENSORS_L3GD20_BUFFER_SIZE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d edited a comment on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
v01d edited a comment on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729102603
Can you move the check for HPWORK define in code to Kconfig, only for when BUFFER > 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729102603
Can you remove the check for HPWORK define in code to Kconfig, only for when BUFFER > 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729523777
> Can you move the check for HPWORK define in code to Kconfig, only for when BUFFER > 0?
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-730193026
> Actually I requested for the check for HPWORK to be moved to Kconfig, but maybe I wasn't clear. I imagine you can select HPWORK if buffer size > 0. This avoids trial and error building.
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-730107509
@v01d is the PR ready for merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org