[GitHub] [spark] srielau commented on a diff in pull request #40474: [SPARK-42849] [WIP] [SQL] Session Variables

["srielau (via GitHub)" <gi...@apache.org>]

srielau commented on code in PR #40474:
URL: https://github.com/apache/spark/pull/40474#discussion_r1254616159


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala:
##########
@@ -582,9 +583,29 @@ class SparkSqlAstBuilder extends AstBuilder {
   }
 
   override def visitSetVariable(ctx: SetVariableContext): LogicalPlan = withOrigin(ctx) {
-    val variableName = visitMultipartIdentifier(ctx.multipartIdentifier)
-    val expression = ctx.expression().toString
-    SetVariableCommand(VariableIdentifier(variableName.last), expression)
+    if (ctx.assignmentList().isEmpty) {
+      SetVariableCommand(Seq(VariableIdentifier("var")), "7")

Review Comment:
   This was temporary code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org