[GitHub] [calcite] NobiGo commented on a diff in pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

["NobiGo (via GitHub)" <gi...@apache.org>]

NobiGo commented on code in PR #3405:
URL: https://github.com/apache/calcite/pull/3405#discussion_r1312440471


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -5885,7 +5885,9 @@ private static void checkIf(SqlOperatorFixture f) {
 
     final SqlOperatorFixture f = f0.withLibrary(SqlLibrary.SPARK);
     f.checkScalar("array_compact(array[null, 1, null, 2])", "[1, 2]",
-        "INTEGER ARRAY NOT NULL");
+        "INTEGER NOT NULL ARRAY NOT NULL");
+    f.checkScalar("array_compact(array[1, 2])", "[1, 2]",
+        "INTEGER NOT NULL ARRAY NOT NULL");
     f.checkScalar("array_compact(array[null])", "[]",
         "NULL ARRAY NOT NULL");
     f.checkScalar("array_compact(array(null))", "[]",

Review Comment:
   Two same tests for `array_compact(array[null])`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org