You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:51:29 UTC
[GitHub] [incubator-echarts] pissang commented on a change in pull request #13039: fix(time): tooltip formatter for time axis
pissang commented on a change in pull request #13039:
URL: https://github.com/apache/incubator-echarts/pull/13039#discussion_r462124335
##########
File path: src/util/format.ts
##########
@@ -93,21 +94,30 @@ export function formatTpl(
return '';
}
- const $vars = paramsList[0].$vars || [];
- for (let i = 0; i < $vars.length; i++) {
- const alias = TPL_VAR_ALIAS[i];
- tpl = tpl.replace(wrapVar(alias), wrapVar(alias, 0));
+ const isTimeAxis = paramsList[0].axisType.indexOf('time') >= 0;
Review comment:
Unfortunately yes. Committed the missded file.
##########
File path: src/util/format.ts
##########
@@ -93,21 +94,30 @@ export function formatTpl(
return '';
}
- const $vars = paramsList[0].$vars || [];
- for (let i = 0; i < $vars.length; i++) {
- const alias = TPL_VAR_ALIAS[i];
- tpl = tpl.replace(wrapVar(alias), wrapVar(alias, 0));
+ const isTimeAxis = paramsList[0].axisType.indexOf('time') >= 0;
Review comment:
Unfortunately yes. Committed the missed file.
##########
File path: src/util/format.ts
##########
@@ -93,21 +94,30 @@ export function formatTpl(
return '';
}
- const $vars = paramsList[0].$vars || [];
- for (let i = 0; i < $vars.length; i++) {
- const alias = TPL_VAR_ALIAS[i];
- tpl = tpl.replace(wrapVar(alias), wrapVar(alias, 0));
+ const isTimeAxis = paramsList[0].axisType.indexOf('time') >= 0;
Review comment:
Unfortunately yes. Committed the missed file. https://github.com/apache/incubator-echarts/commit/70fa023d21bb1205fe5e87122b830c75c658e74a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org