You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abhijeet Gaikwad <ab...@apache.org> on 2013/06/03 12:36:22 UTC
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21310
-----------------------------------------------------------
Huge patch, thanks for the contribution!
I see some unrelated code in the patch. Let me know if you need any help cleaning that up.
I am yet to review the patch thoroughly, but it may take time. I would be more than happy if anyone else reviews and commits this before. Thanks!
conf/MSTest.properties
<https://reviews.apache.org/r/10987/#comment44207>
Some unused properties in this file.
src/test/org/apache/sqoop/manager/MSSQLTestUtils.java
<https://reviews.apache.org/r/10987/#comment44208>
We can remove these privates.
- Abhijeet Gaikwad
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Shuaishuai Nie <sh...@microsoft.com>.
> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > conf/MSTest.properties, line 1
> > <https://reviews.apache.org/r/10987/diff/5/?file=295730#file295730line1>
> >
> > Some unused properties in this file.
removed unused properties in the file
> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > src/test/org/apache/sqoop/manager/MSSQLTestUtils.java, line 46
> > <https://reviews.apache.org/r/10987/diff/5/?file=295735#file295735line46>
> >
> > We can remove these privates.
removed from code
- Shuaishuai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21310
-----------------------------------------------------------
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>
Re: Review Request: Review request for SQOOP-1035 "Add MS Sqoop Connecter
tests to repo"
Posted by Jarek Cecho <ja...@apache.org>.
> On June 3, 2013, 10:36 a.m., Abhijeet Gaikwad wrote:
> > Huge patch, thanks for the contribution!
> > I see some unrelated code in the patch. Let me know if you need any help cleaning that up.
> >
> > I am yet to review the patch thoroughly, but it may take time. I would be more than happy if anyone else reviews and commits this before. Thanks!
Yup, I'll take a look as well.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10987/#review21310
-----------------------------------------------------------
On May 23, 2013, 5:55 p.m., Shuaishuai Nie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10987/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 5:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Add the MS Sqoop connector tests that test integration scenarios with SQL Server to the repo.
>
>
> This addresses bug SQOOP-1035.
> https://issues.apache.org/jira/browse/SQOOP-1035
>
>
> Diffs
> -----
>
> conf/MSTest.properties PRE-CREATION
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 462ccf1
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 27860c2
> src/test/org/apache/sqoop/manager/MSSQLTestData.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestDataFileParser.java PRE-CREATION
> src/test/org/apache/sqoop/manager/MSSQLTestUtils.java PRE-CREATION
> src/test/org/apache/sqoop/manager/ManagerCompatExport.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeExportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportDelimitedFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerDatatypeImportSequenceFileManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerHiveImportManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerManagerManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiColsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerMultiMapsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerParseMethodsManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerQueryManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerSplitByManualTest.java PRE-CREATION
> src/test/org/apache/sqoop/manager/SQLServerWhereManualTest.java PRE-CREATION
> testdata/DatatypeTestData-export-lite.txt PRE-CREATION
> testdata/DatatypeTestData-import-lite.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10987/diff/
>
>
> Testing
> -------
>
> All tests passing after applying the patch
>
>
> Thanks,
>
> Shuaishuai Nie
>
>