You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/07 15:33:19 UTC
[GitHub] [fineract] renovate-bot opened a new pull request #1001: Update dependency gradle to v6.5
renovate-bot opened a new pull request #1001:
URL: https://github.com/apache/fineract/pull/1001
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [gradle](https://gradle.org) ([source](https://togithub.com/gradle/gradle)) | minor | `6.4` -> `6.5` |
---
### Release Notes
<details>
<summary>gradle/gradle</summary>
### [`v6.4.1`](https://togithub.com/gradle/gradle/releases/v6.4.1)
This is a patch release for Gradle 6.4.
This fixes several critical bugs in Gradle 6.4:
- Regression: Different daemons are used between IDE and CLI builds for the same project [#​13069](https://togithub.com/gradle/gradle/issues/13069)
- Regression: Main-Class attribute always added to jar manifest when using application plugin [#​13057](https://togithub.com/gradle/gradle/issues/13057)
[All issues fixed in this patch release](https://togithub.com/gradle/gradle/milestone/145?closed=1)
We recommend that you use Gradle 6.4.1 over the initial release of Gradle 6.4.
#### Upgrade Instructions
Switch your build to use Gradle 6.4.1 by updating your wrapper:
`./gradlew wrapper --gradle-version=6.4.1`
See the [Gradle 6.x upgrade guide](https://docs.gradle.org/6.4.1/userguide/upgrading_version_6.html#changes_6.4) to learn about deprecations, breaking changes and other considerations when upgrading to Gradle 6.4.1.
#### Reporting Problems
If you find a problem with this release, please file a bug on [GitHub Issues](https://togithub.com/gradle/gradle/issues) adhering to our issue guidelines.
If you're not sure you're encountering a bug, please use the [forum](https://discuss.gradle.org/c/help-discuss).
</details>
---
### Renovate configuration
:date: **Schedule**: At any time (no schedule defined).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#apache/fineract).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1001: Update dependency gradle to v6.5
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1001:
URL: https://github.com/apache/fineract/pull/1001#issuecomment-643755207
@rarkins it worked! Neat... Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1001: Update dependency gradle to v6.5
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1001:
URL: https://github.com/apache/fineract/pull/1001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1001: Update dependency gradle to v6.5
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1001:
URL: https://github.com/apache/fineract/pull/1001#issuecomment-642903263
@rarkins may I provide you some RenovateBot feedback here? This PR is incorrect, because:
Upgrading Gradle from 6.4 to 6.5 as per https://docs.gradle.org/6.5/release-notes.html using:
./gradlew wrapper --gradle-version=6.5
should also update `fineract-provider/gradle/wrapper/gradle-wrapper.jar`, `fineract-provider/gradlew`, and `fineract-provider/gradlew.bat` - and not just the `gradle-wrapper.properties` which so far is included. Perhaps that's something you'd like to fix?
PS: In this case now, I don't think it's our `.gitignore`'s fault anymore like we had discussed in FINERACT-962, as #994 is long in, and while [this project's .gitnore](https://github.com/apache/fineract/blob/develop/.gitignore) still contains `.gradle`, the above mentioned files missing here aren't (shouldn't) be matched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1001: Update dependency gradle to v6.5
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1001:
URL: https://github.com/apache/fineract/pull/1001#issuecomment-640254614
I've noticed this ONLY changes the URL, but doesn't update the Wrapper JAR, like #837 did.. I want to compare that with a manual Gradle upgrade, before we merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] rarkins commented on pull request #1001: Update dependency gradle to v6.5
Posted by GitBox <gi...@apache.org>.
rarkins commented on pull request #1001:
URL: https://github.com/apache/fineract/pull/1001#issuecomment-643069979
@vorburger we do actually have the functionality for updating the additional files, but it didn't work correctly. Looking at the source code, I think it's been thrown off by the subdirectory: https://github.com/renovatebot/renovate/blob/1c924059ae7e8cec5a1174bf396ea1202c89e494/lib/manager/gradle-wrapper/artifacts.ts#L97-L107
This should be easily fixable, after which I'll let you know and you can request a rebase of this PR to (hopefully) get the full files in the update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] rarkins commented on pull request #1001: Update dependency gradle to v6.5
Posted by GitBox <gi...@apache.org>.
rarkins commented on pull request #1001:
URL: https://github.com/apache/fineract/pull/1001#issuecomment-643197572
@vorburger this is hopefully now resolved. Could you try checking the rebase/retry checkbox above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org