You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2021/01/18 01:25:21 UTC

[GitHub] [incubator-ratis] amaliujia opened a new pull request #395: [Build] add summary of failures to CI checks

amaliujia opened a new pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395


   ## What changes were proposed in this pull request?
   
   add summary of failures to CI checks 
   
   ## What is the link to the Apache JIRA
   
   TBD
   
   ## How was this patch tested?
   
   N/A
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395#issuecomment-761982406


   @runzhiwang 
   
   Currently that detailed error message is not printed into the summary.txt. We might can write customized script but that will need more work plus I guess those script will likely be fragile.
   
   The summary of failed test name is useful already: we can know which has failed and go back to log to search the test name and then can find the error message.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] runzhiwang merged pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395#issuecomment-761943677


   This is the screenshot  to show that the `summary of  failures` is setup properly.
   
   ![截屏2021-01-17 下午6 42 24](https://user-images.githubusercontent.com/1938382/104866671-fa071f00-58f3-11eb-8c88-9f97aca48f6b.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395#issuecomment-761943411


   R: @runzhiwang @szetszwo 
   
   I found this `summary of failures` was pretty useful when I work with Ozone. So I can see a list of failed tests directly without the need to dig into the long log from running the unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia commented on pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395#issuecomment-761988463


   Meanwhile I will leave the failed CI check here as this PR does not change any code. The failed CI check is also a way to approve this PR is working.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] amaliujia edited a comment on pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395#issuecomment-761943411


   R: @runzhiwang @szetszwo 
   
   I found this `summary of failures` was pretty useful when I worked on Ozone. So I can see a list of failed tests directly without the need to dig into the long log from running the unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] runzhiwang commented on pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395#issuecomment-762006435


   @amaliujia Thanks the patch. I have merged it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-ratis] runzhiwang commented on pull request #395: RATIS-1288. Add summary of failures to CI checks

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #395:
URL: https://github.com/apache/incubator-ratis/pull/395#issuecomment-761946177


   @amaliujia Can we print more detailed message of failed ut in summary.txt ? For example:
   ![image](https://user-images.githubusercontent.com/51938049/104867208-52cdca80-597b-11eb-8be0-fb94d24de51a.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org