You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/14 14:06:09 UTC

[GitHub] [iotdb] liuminghui233 opened a new pull request #4830: [IOTDB-2403] The parameter "ascending" is not set correctly when getting QueryDataSource

liuminghui233 opened a new pull request #4830:
URL: https://github.com/apache/iotdb/pull/4830


   The parameter "ascending" is not set correctly when getting QueryDataSource.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 commented on a change in pull request #4830: [IOTDB-2403] The parameter "ascending" is not set correctly when getting QueryDataSource

Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on a change in pull request #4830:
URL: https://github.com/apache/iotdb/pull/4830#discussion_r785282418



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/lastCache/LastCacheManager.java
##########
@@ -222,7 +222,7 @@ public static long getLastTimeStamp(IMeasurementMNode node, QueryContext queryCo
       try {
         QueryDataSource dataSource =
             QueryResourceManager.getInstance()
-                .getQueryDataSource(node.getPartialPath(), queryContext, null);
+                .getQueryDataSource(node.getPartialPath(), queryContext, null, false);

Review comment:
       fixed

##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/LinearFill.java
##########
@@ -153,7 +153,8 @@ public TimeValuePair getFillResult()
   protected TimeValuePair calculatePrecedingPoint()
       throws QueryProcessException, StorageEngineException, IOException {
     QueryDataSource dataSource =
-        QueryResourceManager.getInstance().getQueryDataSource(seriesPath, context, beforeFilter);
+        QueryResourceManager.getInstance()
+            .getQueryDataSource(seriesPath, context, beforeFilter, false);

Review comment:
       fixed

##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/PreviousFill.java
##########
@@ -115,7 +115,8 @@ public void configureFill(
   public TimeValuePair getFillResult()
       throws IOException, QueryProcessException, StorageEngineException {
     QueryDataSource dataSource =
-        QueryResourceManager.getInstance().getQueryDataSource(seriesPath, context, timeFilter);
+        QueryResourceManager.getInstance()
+            .getQueryDataSource(seriesPath, context, timeFilter, false);

Review comment:
       fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4830: [IOTDB-2403] The parameter "ascending" is not set correctly when getting QueryDataSource

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4830:
URL: https://github.com/apache/iotdb/pull/4830#issuecomment-1013252140


   
   [![Coverage Status](https://coveralls.io/builds/45637637/badge)](https://coveralls.io/builds/45637637)
   
   Coverage increased (+0.05%) to 68.109% when pulling **c4acd1281b880a562839a6a57d657b9a4d842e64 on liuminghui233:unseq_query_debug** into **2f49925eb06055e85bc2495838783b01d6dc192b on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4830: [IOTDB-2403] The parameter "ascending" is not set correctly when getting QueryDataSource

Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on a change in pull request #4830:
URL: https://github.com/apache/iotdb/pull/4830#discussion_r785266596



##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/lastCache/LastCacheManager.java
##########
@@ -222,7 +222,7 @@ public static long getLastTimeStamp(IMeasurementMNode node, QueryContext queryCo
       try {
         QueryDataSource dataSource =
             QueryResourceManager.getInstance()
-                .getQueryDataSource(node.getPartialPath(), queryContext, null);
+                .getQueryDataSource(node.getPartialPath(), queryContext, null, false);

Review comment:
       Add a comment, `true` or `false` both ok here, because LastPointerReader will do itself sort logic instead of depending on `fillOrderIndex`.

##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/LinearFill.java
##########
@@ -153,7 +153,8 @@ public TimeValuePair getFillResult()
   protected TimeValuePair calculatePrecedingPoint()
       throws QueryProcessException, StorageEngineException, IOException {
     QueryDataSource dataSource =
-        QueryResourceManager.getInstance().getQueryDataSource(seriesPath, context, beforeFilter);
+        QueryResourceManager.getInstance()
+            .getQueryDataSource(seriesPath, context, beforeFilter, false);

Review comment:
       The same as above

##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/PreviousFill.java
##########
@@ -115,7 +115,8 @@ public void configureFill(
   public TimeValuePair getFillResult()
       throws IOException, QueryProcessException, StorageEngineException {
     QueryDataSource dataSource =
-        QueryResourceManager.getInstance().getQueryDataSource(seriesPath, context, timeFilter);
+        QueryResourceManager.getInstance()
+            .getQueryDataSource(seriesPath, context, timeFilter, false);

Review comment:
       Same as above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JackieTien97 merged pull request #4830: [IOTDB-2403] The parameter "ascending" is not set correctly when getting QueryDataSource

Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4830:
URL: https://github.com/apache/iotdb/pull/4830


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org