You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/09 15:19:58 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24345: feat: Convert ENABLE_BROAD_ACTIVITY_ACCESS and MENU_HIDE_USER_INFO into feature flags
codecov[bot] commented on PR #24345:
URL: https://github.com/apache/superset/pull/24345#issuecomment-1584756529
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24345](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c21355e) into [master](https://app.codecov.io/gh/apache/superset/commit/bdb8bbef32cf9f782b6a7dc7a93c1ad737712536?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bdb8bbe) will **decrease** coverage by `11.26%`.
> The diff coverage is `33.33%`.
> :exclamation: Current head c21355e differs from pull request most recent head f016fdf. Consider uploading reports for the commit f016fdf to get more accurate results
```diff
@@ Coverage Diff @@
## master #24345 +/- ##
===========================================
- Coverage 69.08% 57.82% -11.26%
===========================================
Files 1905 1905
Lines 74848 74845 -3
Branches 8108 8108
===========================================
- Hits 51705 43276 -8429
- Misses 21031 29457 +8426
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.59% <33.33%> (-0.01%)` | :arrow_down: |
| python | `60.14% <33.33%> (-23.13%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.08% <33.33%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/pages/ChartList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0NoYXJ0TGlzdC9pbmRleC50c3g=) | `55.00% <ø> (-0.32%)` | :arrow_down: |
| [...uperset-frontend/src/pages/DashboardList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Rhc2hib2FyZExpc3QvaW5kZXgudHN4) | `55.37% <ø> (-0.37%)` | :arrow_down: |
| [superset/config.py](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.45% <ø> (-0.62%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `74.08% <0.00%> (-15.69%)` | :arrow_down: |
| [superset/models/dashboard.py](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `48.09% <0.00%> (-30.92%)` | :arrow_down: |
| [superset/models/slice.py](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `58.21% <0.00%> (-29.58%)` | :arrow_down: |
| [superset/views/base.py](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `61.90% <ø> (-15.31%)` | :arrow_down: |
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `36.47% <ø> (-38.81%)` | :arrow_down: |
| [superset/models/filter\_set.py](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2ZpbHRlcl9zZXQucHk=) | `64.17% <50.00%> (-13.44%)` | :arrow_down: |
| ... and [1 more](https://app.codecov.io/gh/apache/superset/pull/24345?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [295 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24345/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org