You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/13 12:27:37 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #11084:
[FLINK-16040][python] Change local import to global import
HuangXingBo opened a new pull request #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084
## What is the purpose of the change
*This pull request will change local import to global import*
## Brief change log
- *change local import to global import*
## Verifying this change
This change added tests and can be verified as follows:
- *tox test*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11084:
[FLINK-16040][python] Change local import to global import
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-585745264
<!--
Meta data
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148784336 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5140 TriggerType:PUSH TriggerID:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35
Hash:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148807558 TriggerType:PUSH TriggerID:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35
-->
## CI report:
* de71560318a440a2874da4ab566edcdafa16c543 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148784336) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138)
* 32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148807558) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5140)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11084: [FLINK-16040][python]
Change local import to global import
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-585745264
<!--
Meta data
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
-->
## CI report:
* de71560318a440a2874da4ab566edcdafa16c543 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11084:
[FLINK-16040][python] Change local import to global import
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-585745264
<!--
Meta data
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148784336 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5140 TriggerType:PUSH TriggerID:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35
Hash:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148807558 TriggerType:PUSH TriggerID:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35
-->
## CI report:
* de71560318a440a2874da4ab566edcdafa16c543 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148784336) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138)
* 32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148807558) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5140)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11084:
[FLINK-16040][python] Change local import to global import
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-585745264
<!--
Meta data
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148784336 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35
-->
## CI report:
* de71560318a440a2874da4ab566edcdafa16c543 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148784336) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138)
* 32ccda04c91cbf16cd3e0aaa07feb5e7bd4c8e35 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu edited a comment on issue #11084:
[FLINK-16040][python] Change local import to global import
Posted by GitBox <gi...@apache.org>.
dianfu edited a comment on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-586051943
@HuangXingBo Thanks for the PR and sharing the performance data. The performance gain is impressive. LGTM. Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11084: [FLINK-16040][python]
Change local import to global import
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-585732397
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 73db28ab7cdc1c0eb78e5f32b9dd22b16ee2836d (Thu Feb 13 12:29:28 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16040).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu merged pull request #11084: [FLINK-16040][python]
Change local import to global import
Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11084:
[FLINK-16040][python] Change local import to global import
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-585745264
<!--
Meta data
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148784336 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
-->
## CI report:
* de71560318a440a2874da4ab566edcdafa16c543 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148784336) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11084:
[FLINK-16040][python] Change local import to global import
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-585745264
<!--
Meta data
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
Hash:de71560318a440a2874da4ab566edcdafa16c543 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148784336 TriggerType:PUSH TriggerID:de71560318a440a2874da4ab566edcdafa16c543
-->
## CI report:
* de71560318a440a2874da4ab566edcdafa16c543 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148784336) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5138)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on issue #11084: [FLINK-16040][python]
Change local import to global import
Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11084: [FLINK-16040][python] Change local import to global import
URL: https://github.com/apache/flink/pull/11084#issuecomment-586051943
LGTM. Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services