You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/05/22 06:01:52 UTC

[GitHub] beiwei30 commented on issue #1627: [Dubbo- demo easy to use ] enhance for demo start.

beiwei30 commented on issue #1627: [Dubbo- demo easy to use ] enhance for demo start.
URL: https://github.com/apache/incubator-dubbo/pull/1627#issuecomment-390872724
 
 
   @zonghaishang I don't agree with this change because this change adds more cost for the user to quick learn how dubbo works. The original code is quite straightforward. Considering we will eventually remove dubbo-demo from this project, you may consider add one new samples in https://github.com/dubbo/dubbo-samples to demostrate graceful shutdown, and graceful shutdown only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org