You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/09/08 10:00:03 UTC
[GitHub] [maven-plugin-tools] kwin opened a new pull request, #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
kwin opened a new pull request, #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226
Add example JDK21 generated javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1327949273
##########
maven-plugin-tools-api/pom.xml:
##########
@@ -125,4 +130,30 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>run-its</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ <configuration>
+ <!-- don't run ITs against all (non-LTS) JDK javadocs -->
+ <excludedGroups>nonLtsJavadocs</excludedGroups>
Review Comment:
ok. I see test are execute - only not the non lst are extracted to other test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1321068846
##########
maven-plugin-tools-api/pom.xml:
##########
@@ -125,4 +130,30 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>run-its</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ <configuration>
+ <!-- don't run ITs against all (non-LTS) JDK javadocs -->
+ <excludedGroups>nonLtsJavadocs</excludedGroups>
Review Comment:
always testing against all ever released JDKs just takes too much time. It is rather advisable to execute that IT manually in case something was fundamentally changed about link creation which might affect all versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1320586769
##########
maven-plugin-tools-api/pom.xml:
##########
@@ -125,4 +130,30 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>run-its</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ <configuration>
+ <!-- don't run ITs against all (non-LTS) JDK javadocs -->
+ <excludedGroups>nonLtsJavadocs</excludedGroups>
Review Comment:
If we here exclude tests with this tag - where such tests will be executed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1327945771
##########
maven-plugin-tools-api/pom.xml:
##########
@@ -125,4 +130,30 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>run-its</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ <configuration>
+ <!-- don't run ITs against all (non-LTS) JDK javadocs -->
+ <excludedGroups>nonLtsJavadocs</excludedGroups>
Review Comment:
Any other concerns @slawekjaranowski?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] kwin merged pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1320628763
##########
maven-plugin-tools-api/pom.xml:
##########
@@ -125,4 +130,30 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>run-its</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ <configuration>
+ <!-- don't run ITs against all (non-LTS) JDK javadocs -->
+ <excludedGroups>nonLtsJavadocs</excludedGroups>
Review Comment:
only locally if you override that parameter or execute that IT in your IDE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #226: [MPLUGIN-482] Consider implicit module name for javadoc URL calculation
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #226:
URL: https://github.com/apache/maven-plugin-tools/pull/226#discussion_r1320628763
##########
maven-plugin-tools-api/pom.xml:
##########
@@ -125,4 +130,30 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>run-its</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-failsafe-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>integration-test</goal>
+ <goal>verify</goal>
+ </goals>
+ <configuration>
+ <!-- don't run ITs against all (non-LTS) JDK javadocs -->
+ <excludedGroups>nonLtsJavadocs</excludedGroups>
Review Comment:
only if you override that parameter or execute that IT in your IDE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org