You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sv...@apache.org on 2004/12/09 06:13:02 UTC
cvs commit: incubator-myfaces/src/components/org/apache/myfaces/custom/date HtmlDateRenderer.java
svieujot 2004/12/08 21:13:02
Modified: src/components/org/apache/myfaces/custom/calendar
HtmlCalendarRenderer.java
src/components/org/apache/myfaces/custom/date
HtmlDateRenderer.java
Log:
Mark potential bugs where we use the backing bean's value, and do not check for submitted value
Revision Changes Path
1.13 +5 -2 incubator-myfaces/src/components/org/apache/myfaces/custom/calendar/HtmlCalendarRenderer.java
Index: HtmlCalendarRenderer.java
===================================================================
RCS file: /home/cvs/incubator-myfaces/src/components/org/apache/myfaces/custom/calendar/HtmlCalendarRenderer.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- HtmlCalendarRenderer.java 2 Dec 2004 22:26:23 -0000 1.12
+++ HtmlCalendarRenderer.java 9 Dec 2004 05:13:02 -0000 1.13
@@ -46,6 +46,9 @@
/**
* $Log$
+ * Revision 1.13 2004/12/09 05:13:02 svieujot
+ * Mark potential bugs where we use the backing bean's value, and do not check for submitted value
+ *
* Revision 1.12 2004/12/02 22:26:23 svieujot
* Simplify the AddResource methods
*
@@ -104,7 +107,7 @@
Locale currentLocale = facesContext.getViewRoot().getLocale();
- Date value = (Date) inputCalendar.getValue();
+ Date value = (Date) inputCalendar.getValue(); // TODO : Check if restores submitted value.
Calendar timeKeeper = Calendar.getInstance(currentLocale);
timeKeeper.setTime(value!=null?value:new Date());
1.10 +6 -3 incubator-myfaces/src/components/org/apache/myfaces/custom/date/HtmlDateRenderer.java
Index: HtmlDateRenderer.java
===================================================================
RCS file: /home/cvs/incubator-myfaces/src/components/org/apache/myfaces/custom/date/HtmlDateRenderer.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- HtmlDateRenderer.java 13 Oct 2004 11:50:57 -0000 1.9
+++ HtmlDateRenderer.java 9 Dec 2004 05:13:02 -0000 1.10
@@ -38,6 +38,9 @@
/**
* $Log$
+ * Revision 1.10 2004/12/09 05:13:02 svieujot
+ * Mark potential bugs where we use the backing bean's value, and do not check for submitted value
+ *
* Revision 1.9 2004/10/13 11:50:57 matze
* renamed packages to org.apache
*
@@ -100,7 +103,7 @@
HtmlInputDate inputDate = (HtmlInputDate) uiComponent;
Locale currentLocale = facesContext.getViewRoot().getLocale();
- UserData userData = inputDate.getUserData(currentLocale);
+ UserData userData = inputDate.getUserData(currentLocale); // TODO : Check if restores the submitted value
String type = inputDate.getType();
String clientId = uiComponent.getClientId(facesContext);