You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "jiangpengcheng (via GitHub)" <gi...@apache.org> on 2023/02/09 02:24:17 UTC

[GitHub] [pulsar] jiangpengcheng opened a new pull request, #19470: Support compression

jiangpengcheng opened a new pull request, #19470:
URL: https://github.com/apache/pulsar/pull/19470

   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   -->
   
   <!-- Either this PR fixes an issue, -->
   
   Fixes #19462 
   
   <!-- or this PR is one task of an issue -->
   
   <!-- If the PR belongs to a PIP, please add the PIP link here -->
   
   
   <!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
   
   ### Motivation
   
   <!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
   
   ### Modifications
   
   <!-- Describe the modifications you've done. -->
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [x] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/jiangpengcheng/pulsar/pull/6
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1463456660

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui closed pull request #19470: [improve][fn] Support configure compression type

Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui closed pull request #19470: [improve][fn] Support configure compression type
URL: https://github.com/apache/pulsar/pull/19470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1452789272

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1480721463

   This PR broke the master branch. Please review and merge #19904 asap to fix master. 
   The reason why this PR was mergeable is due to a CI bug #19905 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1461118517

   @momo-jun a new field `CompressionType` should be added to `ProducerConfig`: https://pulsar.apache.org/docs/next/functions-cli/#producerconfig,
   
   the type is `String` and available values are: `None`, `LZ4`, `ZLIB`, `ZSTD` and `SNAPPY`, and default to `LZ4`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nlu90 commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "nlu90 (via GitHub)" <gi...@apache.org>.
nlu90 commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1476597277

   Hi @michaeljmarshall, a mail thread sent on February 28 discussed the change. 
   PTAL: https://lists.apache.org/thread/8z849bhp79ob23kf1p21f6kq7rd6bljq
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] michaeljmarshall commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1477276742

   Thanks for that link @nlu90! Looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1425570541

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nlu90 commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "nlu90 (via GitHub)" <gi...@apache.org>.
nlu90 commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1442821001

   @jiangpengcheng 
   Since this PR involves protobuf change, let's send an email in the mailing list to let folks in the community know about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nlu90 closed pull request #19470: [improve][fn] Support configure compression type

Posted by "nlu90 (via GitHub)" <gi...@apache.org>.
nlu90 closed pull request #19470: [improve][fn] Support configure compression type
URL: https://github.com/apache/pulsar/pull/19470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1461119487

   > Details
   
   added go support and suggestions to docs update


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1457445885

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nlu90 commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "nlu90 (via GitHub)" <gi...@apache.org>.
nlu90 commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1462471583

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1463456470

   > > the type is `String` and available values are: `None`, `LZ4`, `ZLIB`, `ZSTD` and `SNAPPY`, and default to `LZ4`
   > 
   > @jiangpengcheng thanks for the input. I've drafted [apache/pulsar-site#461](https://github.com/apache/pulsar-site/pull/461) to add the docs. Only one concern - the default config of compression type on client side, e.g., Java producers, is `None` (no compression), which is not aligned with functions. Is there any risk here?
   
   
   There is no risk, just for back compatibility since current pulsar functions are using `LZ4` as compression type.
   
   One thing I did wrong is that the `None` should be `NONE` instead
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1426217839

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19470](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8976c3) into [master](https://codecov.io/gh/apache/pulsar/commit/016e7f0af997788d0514ca64e2c5c1bd9f506863?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (016e7f0) will **increase** coverage by `37.69%`.
   > The diff coverage is `53.40%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/19470/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #19470       +/-   ##
   =============================================
   + Coverage     24.75%   62.45%   +37.69%     
   - Complexity      288     3475     +3187     
   =============================================
     Files          1579     1832      +253     
     Lines        121841   134257    +12416     
     Branches      13304    14774     +1470     
   =============================================
   + Hits          30164    83846    +53682     
   + Misses        87240    42741    -44499     
   - Partials       4437     7670     +3233     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `24.85% <6.81%> (+0.09%)` | :arrow_up: |
   | systests | `25.52% <34.09%> (?)` | |
   | unittests | `59.71% <48.86%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...a/org/apache/pulsar/functions/sink/PulsarSink.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy9pbnN0YW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Z1bmN0aW9ucy9zaW5rL1B1bHNhclNpbmsuamF2YQ==) | `66.05% <33.33%> (+66.05%)` | :arrow_up: |
   | [...va/org/apache/pulsar/broker/service/ServerCnx.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1NlcnZlckNueC5qYXZh) | `54.59% <46.15%> (+22.93%)` | :arrow_up: |
   | [.../pulsar/client/impl/auth/AuthenticationAthenz.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC1hdXRoLWF0aGVuei9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL2F1dGgvQXV0aGVudGljYXRpb25BdGhlbnouamF2YQ==) | `59.45% <50.00%> (ø)` | |
   | [.../apache/pulsar/functions/utils/FunctionCommon.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy91dGlscy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Z1bmN0aW9ucy91dGlscy9GdW5jdGlvbkNvbW1vbi5qYXZh) | `59.84% <50.00%> (+59.84%)` | :arrow_up: |
   | [...he/pulsar/functions/utils/FunctionConfigUtils.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy91dGlscy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Z1bmN0aW9ucy91dGlscy9GdW5jdGlvbkNvbmZpZ1V0aWxzLmphdmE=) | `62.92% <50.00%> (+62.92%)` | :arrow_up: |
   | [...apache/pulsar/common/functions/ProducerConfig.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC1hZG1pbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jb21tb24vZnVuY3Rpb25zL1Byb2R1Y2VyQ29uZmlnLmphdmE=) | `90.90% <100.00%> (+90.90%)` | :arrow_up: |
   | [...ulsar/functions/instance/JavaInstanceRunnable.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy9pbnN0YW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Z1bmN0aW9ucy9pbnN0YW5jZS9KYXZhSW5zdGFuY2VSdW5uYWJsZS5qYXZh) | `54.63% <100.00%> (+54.63%)` | :arrow_up: |
   | [...ache/pulsar/functions/utils/SourceConfigUtils.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWZ1bmN0aW9ucy91dGlscy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Z1bmN0aW9ucy91dGlscy9Tb3VyY2VDb25maWdVdGlscy5qYXZh) | `63.26% <100.00%> (+63.26%)` | :arrow_up: |
   | [...in/java/org/apache/pulsar/common/api/AuthData.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jb21tb24vYXBpL0F1dGhEYXRhLmphdmE=) | `71.42% <0.00%> (ø)` | |
   | [.../apache/pulsar/broker/namespace/LookupOptions.java](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9uYW1lc3BhY2UvTG9va3VwT3B0aW9ucy5qYXZh) | `87.50% <0.00%> (ø)` | |
   | ... and [1376 more](https://codecov.io/gh/apache/pulsar/pull/19470?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1442859937

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nlu90 merged pull request #19470: [improve][fn] Support configure compression type

Posted by "nlu90 (via GitHub)" <gi...@apache.org>.
nlu90 merged PR #19470:
URL: https://github.com/apache/pulsar/pull/19470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1425314366

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1459602624

   @tisonkun thanks for considering the doc development.
   @jiangpengcheng To scope the incremental doc updates, I think at least we have a new config that needs to be added to [this topic](https://pulsar.apache.org/docs/next/functions-cli/#yaml-configurations-for-pulsar-functions). Can you please confirm and advise? It would be great if you could analyze the user impact of this improvement and involve the doc updates within this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1461479876

   > the type is `String` and available values are: `None`, `LZ4`, `ZLIB`, `ZSTD` and `SNAPPY`, and default to `LZ4`
   
   @jiangpengcheng thanks for the input. I've drafted https://github.com/apache/pulsar-site/pull/461 to add the docs.
   Only one concern - the default config of compression type on client side, e.g., Java producers, is `None` (no compression), which is not aligned with functions. Is there any risk here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1457666501

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] michaeljmarshall commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1474125400

   This updates the function proto. Shouldn't we have had a PIP?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1465354888

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] jiangpengcheng commented on pull request #19470: [improve][fn] Support configure compression type

Posted by "jiangpengcheng (via GitHub)" <gi...@apache.org>.
jiangpengcheng commented on PR #19470:
URL: https://github.com/apache/pulsar/pull/19470#issuecomment-1439500394

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org