You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/22 22:21:03 UTC
[GitHub] [airflow] kaxil commented on a change in pull request #11753: Fix FAB actions with for models with composite PKs
kaxil commented on a change in pull request #11753:
URL: https://github.com/apache/airflow/pull/11753#discussion_r510490921
##########
File path: airflow/www/utils.py
##########
@@ -437,6 +439,42 @@ def is_utcdatetime(self, col_name):
isinstance(obj.impl, UtcDateTime)
return False
+ # This is a local fix until https://github.com/dpgaspar/Flask-AppBuilder/pull/1493 is merged and released.
+ def get(
+ self,
+ id,
+ filters: Optional[Filters] = None,
+ select_columns: Optional[List[str]] = None,
+ ) -> Any:
+ """
+ Returns the result for a model get, applies filters and supports dotted
+ notation for joins and granular selecting query columns.
+ :param id: The model id (pk).
Review comment:
```suggestion
notation for joins and granular selecting query columns.
:param id: The model id (pk).
```
##########
File path: airflow/www/utils.py
##########
@@ -437,6 +439,42 @@ def is_utcdatetime(self, col_name):
isinstance(obj.impl, UtcDateTime)
return False
+ # This is a local fix until https://github.com/dpgaspar/Flask-AppBuilder/pull/1493 is merged and released.
+ def get(
+ self,
+ id,
+ filters: Optional[Filters] = None,
+ select_columns: Optional[List[str]] = None,
+ ) -> Any:
+ """
+ Returns the result for a model get, applies filters and supports dotted
+ notation for joins and granular selecting query columns.
+ :param id: The model id (pk).
+ :param filters: A Filter class that contains all filters to apply.
+ :param select_columns: A List of columns to be specifically selected.
+ on the query. Supports dotted notation.
+ :return:
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org