[GitHub] [spark] viirya commented on a diff in pull request #36455: [SPARK-39105][SQL] Add ConditionalExpression trait

[GitBox <gi...@apache.org>]

viirya commented on code in PR #36455:
URL: https://github.com/apache/spark/pull/36455#discussion_r866405428


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
##########
@@ -454,6 +454,33 @@ trait Nondeterministic extends Expression {
   protected def evalInternal(input: InternalRow): Any
 }
 
+/**
+ * An expression that contains predicate expression branch, so not all branch will be hit

Review Comment:
   ```suggestion
    * An expression that contains conditional expression branches, so not all branches will be hit
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org