[jclouds/jclouds-labs] Added support for metadata and tags to Azure ARM (#327)

[Ignasi Barrera <no...@github.com>]

Added support for metadata and tags and enabled the ComputeServiceLive tests that validate the behaviour.

/cc @andreaturli 
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/327

-- Commit Summary --

  * Added support for metadata and tags to Azure ARM

-- File Changes --

    M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceAdapter.java (7)
    M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/functions/VirtualMachineToNodeMetadata.java (10)
    M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/VirtualMachineApi.java (6)
    M azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceLiveTest.java (14)
    M azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/VirtualMachineApiLiveTest.java (4)
    M azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/VirtualMachineApiMockTest.java (19)
    M azurecompute-arm/src/test/resources/createvirtualmachineresponse.json (5)
    M azurecompute-arm/src/test/resources/virtualmachine.json (5)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/327.patch
https://github.com/jclouds/jclouds-labs/pull/327.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/327

Re: [jclouds/jclouds-labs] Added support for metadata and tags to Azure ARM (#327)

[Andrea Turli <no...@github.com>]

andreaturli commented on this pull request.



> @@ -177,10 +176,9 @@ public String apply(VirtualMachineStatus input) {
       builder.privateAddresses(getPrivateIpAddresses(virtualMachine.properties().networkProfile().networkInterfaces()));
 
       if (virtualMachine.tags() != null) {
-         Map<String, String> userMetaData = virtualMachine.tags();
-         builder.userMetadata(userMetaData);
-         builder.tags(Splitter.on(",").split(userMetaData.get("tags")));
+         addMetadataAndParseTagsFromCommaDelimitedValue(builder, virtualMachine.tags());

nice! didn't know it 👍 


-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/327#pullrequestreview-4467641