You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2025/08/28 22:10:37 UTC
[PR] fixes for projection matching logic (druid)
clintropolis opened a new pull request, #18451:
URL: https://github.com/apache/druid/pull/18451
### Description
Fixes to projection matching logic, simplifying things by removing some match tracking which could cause bugs and was previously necessary to account for what was a flaw in the unnest `CursorBuildSpec` translation (also joins had this same flaw)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fixes for projection matching logic (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #18451:
URL: https://github.com/apache/druid/pull/18451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fixes for projection matching logic (druid)
Posted by "capistrant (via GitHub)" <gi...@apache.org>.
capistrant commented on code in PR #18451:
URL: https://github.com/apache/druid/pull/18451#discussion_r2319995737
##########
processing/src/main/java/org/apache/druid/segment/UnnestCursorFactory.java:
##########
@@ -475,6 +453,73 @@ public static ColumnCapabilities computeOutputColumnCapabilities(
}
}
+ /**
+ * Converts a {@link CursorBuildSpec} to the base table {@link CursorBuildSpec}, ensuring that all required columns
+ * of are added to {@link CursorBuildSpec#getPhysicalColumns()} and the unnest column is added to {@link CursorBuildSpec#getVirtualColumns()}
Review Comment:
nit: `ensuring that all required columns of ? are added to ...` potentially missing a word where `?` is?
##########
processing/src/main/java/org/apache/druid/segment/UnnestCursorFactory.java:
##########
@@ -475,6 +453,73 @@ public static ColumnCapabilities computeOutputColumnCapabilities(
}
}
+ /**
+ * Converts a {@link CursorBuildSpec} to the base table {@link CursorBuildSpec}, ensuring that all required columns
+ * of are added to {@link CursorBuildSpec#getPhysicalColumns()} and the unnest column is added to {@link CursorBuildSpec#getVirtualColumns()}
+ */
+ @VisibleForTesting
+ public static CursorBuildSpec transformCursorBuildSpec(
Review Comment:
I don't see any usage outside of the `org.apache.druid.segment` package, should this drop the `public` visibility since it is marked as visiblefortesting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org