[PR] hw/mcu/stm/stm32_common: Remove HAL_SPI_Init copy for STM32L1 [mynewt-core]

["kasjer (via GitHub)" <gi...@apache.org>]

kasjer opened a new pull request, #3832:
URL: https://github.com/apache/mynewt-core/pull/3832

   stm32_driver_mod_spi.c had a copy of HAL_SPI_Init() for STM32L152xC. Comment says it was copied from stm32l1xx_hal_spi_ex.c to override weak symbol from stm32l1xx_hal_spi.c that did not link correctly. Current STM32L1 HAL has no stm32l1xx_hal_spi_ex.c and HAL_SPI_Init() is not weak, so the copy only duplicates the HAL function.
   
   If weak implementation from library was linked instead of the strong one, pkg.whole_archive: true in pkg.yml is meant for this kind of situation. With pkg.whole_archive set for stm32_common the copy causes multiple definition error.
   
   Assisted-by: Claude:claude-opus-5-5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] hw/mcu/stm/stm32_common: Remove HAL_SPI_Init copy for STM32L1 [mynewt-core]

["kasjer (via GitHub)" <gi...@apache.org>]

kasjer merged PR #3832:
URL: https://github.com/apache/mynewt-core/pull/3832


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org