You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/07 22:17:58 UTC
[GitHub] [echarts] benlongo opened a new pull request, #16850: Fix prepareCustoms key for Single axis.
benlongo opened a new pull request, #16850:
URL: https://github.com/apache/echarts/pull/16850
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
When using a custom series with a single axis, a lookup on `prepareCustoms` fails as it is looking for `single` instead of `singleAxis`.
### Fixed issues
- custom series on single axis now works
### Related test cases or examples to use the new APIs
If this is the right approach to fixing this, I can put together a reproduction and test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org
[GitHub] [echarts] benlongo commented on pull request #16850: Fix prepareCustoms key for Single axis.
Posted by GitBox <gi...@apache.org>.
benlongo commented on PR #16850:
URL: https://github.com/apache/echarts/pull/16850#issuecomment-1132425115
Sorry for the long delay! I've added a test and confirmed that it is broken on master and that this branch fixes it. I additionally fixed a typo I came across but can pull that into a separate PR if you prefer.
I modified an existing example to reproduce the, which isn't a minimal, but I can make it simpler if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16850: Fix prepareCustoms key for Single axis.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16850:
URL: https://github.com/apache/echarts/pull/16850#issuecomment-1092262726
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #16850: Fix prepareCustoms key for Single axis.
Posted by GitBox <gi...@apache.org>.
pissang merged PR #16850:
URL: https://github.com/apache/echarts/pull/16850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #16850: Fix prepareCustoms key for Single axis.
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #16850:
URL: https://github.com/apache/echarts/pull/16850#issuecomment-1132506745
@benlongo It's fine. All looks good! Well done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #16850: Fix prepareCustoms key for Single axis.
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #16850:
URL: https://github.com/apache/echarts/pull/16850#issuecomment-1093620788
@benlongo Thanks for the contribution and LGTM!. Adding a new test case for this fix will be great! You can append this test case to `test/custom.html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16850: Fix prepareCustoms key for Single axis.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16850:
URL: https://github.com/apache/echarts/pull/16850#issuecomment-1132506926
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org