You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/03/19 00:40:00 UTC
[Bug 4206] New: Don't load Bayes if disabled (use_bayes 0)
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
Summary: Don't load Bayes if disabled (use_bayes 0)
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: All
OS/Version: Windows 95
Status: NEW
Severity: enhancement
Priority: P5
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jgmyers@proofpoint.com
A performance optimization to avoid loading Mail::SpamAssassin::Bayes when
use_bayes is set to 0.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
quinlan@pathname.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.0
------- Additional Comments From quinlan@pathname.com 2005-04-02 19:37 -------
bug with patch -> 3.1 milestone
+1 for me, tests fine for me in limited testing
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From jm@jmason.org 2005-10-06 15:20 -------
I was going to apply this -- but Dallas' point is a good one. Has anyone tested
that situation? (reminder: system-wide settings have "use_bayes 0", user has
"use_bayes 1").
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From jgmyers@proofpoint.com 2005-08-14 15:48 -------
I'm not asking for this to go into 3.1, just the trunk. A 3.0 version of this
patch has been running in production with bayes disabled for months.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From quinlan@pathname.com 2005-08-14 14:02 -------
+0.9 on HEAD only
-1 on 3.1
The reason I'm not fully +1 is because I think we'll plugin-ize Bayes before
3.2 and this will be useful as a reference/precursor work. I would prefer to
just skip this step and go straight to plugin.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From dallase@nmgi.com 2005-08-14 14:39 -------
i'll just throw in a reminder about bug 4448 ;)
so when you do implement this, please dont break SQL prefs where 'use_bayes 0'
is set in a flat file but some users have it 'use_bayes 1' via their SQL prefs...
thanks!
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
jgmyers@proofpoint.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jgmyers@proofpoint.com 2005-10-14 16:14 -------
Committed revision 321240.
Bayes loading is tested in signal_user_changed, which is documented as being
called after reading any per-user configuration.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From duncf@debian.org 2005-08-14 18:35 -------
Right, I think we're all in agreement that this should not go into 3.1 (it's
triaged for 3.2, and it's clearly too late).
Any committer is free to test and commit -- I'll do it if I get around to it
(haha... I've said that before) since we're CTR on trunk. (Just wanted to
clarify that we have no need for a vote)
Since we expressed the desire to have a short release cycle for 3.2, it would be
good to get this in soon so we can test it in case Bayes doesn't get plugininzed
quick enough -- I'm not sure how high a priority that is for Michael/Daniel(?).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From jgmyers@proofpoint.com 2005-03-18 15:41 -------
Created an attachment (id=2714)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2714&action=view)
Proposed fix
Doesn't include any changes to Mail::SpamAssassin::PerMsgLearner. I'm not sure
what it means to learn when Bayes is disabled.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From jm@jmason.org 2005-08-14 14:19 -------
+1 for trunk
-1 for 3.1.0
agreed with Daniel. I'm more ok with getting it into trunk than he is, though.
BTW there may be a safer way to do it without having to risk calls of methods on
an undef value (which is a die()), by making $main->{bayes_scanner} be an
implementation of an object which does no-ops for all the Mail::SA::Bayes
methods. I think this is the Null Object pattern iirc?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
parkerm@pobox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dev@spamassassin.apache.org
AssignedTo|dev@spamassassin.apache.org |parkerm@pobox.com
------- Additional Comments From parkerm@pobox.com 2005-04-05 22:32 -------
Taking.
Eventually this will be a plugin, but not yet so this seems to make some sense.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
parkerm@pobox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|parkerm@pobox.com |dev@spamassassin.apache.org
------- Additional Comments From parkerm@pobox.com 2005-08-13 23:51 -------
I plan to pluginize Bayes and don't have time to test this before putting it in,
so someone else can grab it if they'd like to get it in.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
jgmyers@proofpoint.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|cla |
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
------- Additional Comments From jm@jmason.org 2005-06-07 11:35 -------
John's CLA is noted as received at jimjag's page so this is CLA-ready.
I agree this should go into 3.2.0 though, as it could have big effects in terms
of stability and it's too late for 3.1.0 given that :(
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
quinlan@pathname.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |cla
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4206] Don't load Bayes if disabled (use_bayes 0)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4206
quinlan@pathname.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.1.0 |3.2.0
------- Additional Comments From quinlan@pathname.com 2005-04-30 20:14 -------
punting to 3.2.0
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.