You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/01 23:30:06 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #4586: Fix ORT Traffic Ops timeout 30s

rob05c opened a new pull request #4586: Fix ORT Traffic Ops timeout 30s
URL: https://github.com/apache/trafficcontrol/pull/4586
 
 
   Fixes ORT Traffic Ops timeout to 30s. This is what it's been forever. The recent config gen changes inadvertently changed it to 10s.
   
   This also exposes the timeout as a flag to ORT.
   
   I manually tested, verified the timeout defaults to 30s, and also that the new flag works. I actually watched the timeouts on a hanging server every 30s with the backoff/retry logic, and also set the timeout to 5ms and watched ORT immediately fail with a timeout message.
   
   No tests, ORT doesn't have an integration test framework yet.
   No docs, no changelog, no interface change (from what it was before the 'bug' changed it).
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   - Traffic Portal
   - Traffic Router
   - Traffic Stats
   - Traffic Vault
   
   ## What is the best way to verify this PR?
   Run ORT on a very slow Traffic Ops, verify it handles requests longer than 10s. Set the new ORT flag `--to_timeout_ms=2`, verify it immediately times out and fails on the first request.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   4.0.x
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   ## Additional Information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp merged pull request #4586: Fix ORT Traffic Ops timeout 30s

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #4586: Fix ORT Traffic Ops timeout 30s
URL: https://github.com/apache/trafficcontrol/pull/4586
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services