You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/05 16:49:57 UTC

[GitHub] [airflow] XD-DENG opened a new pull request #8719: Add __repr__ for DagTag so it displays properly in /dagmodel/show

XD-DENG opened a new pull request #8719:
URL: https://github.com/apache/airflow/pull/8719


   Currently Dag Tags are not displayed properly in UI page `/dagmodel/show/<dag_id>`
   
   This issue exists in both `master` and `1.10.10`
   
   ## How to Reproduce
   <img width="794" alt="1" src="https://user-images.githubusercontent.com/11539188/81092568-0fbceb80-8f01-11ea-8f79-338ac19923f5.png">
   
   ## Before Fix
   <img width="964" alt="before_fix" src="https://user-images.githubusercontent.com/11539188/81092600-1fd4cb00-8f01-11ea-87e0-73296912aa57.png">
   
   ## After fix
   <img width="723" alt="after_fix" src="https://user-images.githubusercontent.com/11539188/81092611-24997f00-8f01-11ea-9560-a2e36d29223d.png">
   
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #8719: Add __repr__ for DagTag so it displays properly in /dagmodel/show

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #8719:
URL: https://github.com/apache/airflow/pull/8719#issuecomment-624204550


   Hi @kaxil , unit test is updated. May be a bit "more" than you expected, but I think it's worthwhile


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on pull request #8719: Add __repr__ for DagTag so it displays properly in /dagmodel/show

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #8719:
URL: https://github.com/apache/airflow/pull/8719#issuecomment-624189636


   > can we add a simple test for this?
   
   Thanks @kaxil . I was thinking of this as well, but didn't do it given it's too simple change.
   
   Let me re-think how I should do it. Will update here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #8719: Add __repr__ for DagTag so it displays properly in /dagmodel/show

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8719:
URL: https://github.com/apache/airflow/pull/8719#issuecomment-624192356


   > > can we add a simple test for this?
   > 
   > Thanks @kaxil . I was thinking of this as well, but didn't do it given it's too simple change.
   > 
   > Let me re-think how I should do it. Will update here.
   
   I mean just assert that "repr(ExampleDagTag) == 'ExampleDagTag'" 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org