[GitHub] ctubbsii commented on a change in pull request #6: ACCUMULO-4718 Add HADOOP_CONF_DIR to rw-local cp

[gi...@git.apache.org]

ctubbsii commented on a change in pull request #6: ACCUMULO-4718 Add HADOOP_CONF_DIR to rw-local cp
URL: https://github.com/apache/accumulo-testing/pull/6#discussion_r144427141
 
 

 ##########
 File path: bin/accumulo-testing
 ##########
 @@ -229,7 +229,7 @@ rw-local)
     exit 1
   fi
   build_shade_jar
-  java -Dlog4j.configuration="file:$log4j_config" -cp "$at_shaded_jar" "$randomwalk_main" "$at_props" "$2"
+  java -Dlog4j.configuration="file:$log4j_config" -cp "$at_shaded_jar:$HADOOP_CONF_DIR" "$randomwalk_main" "$at_props" "$2"
 
 Review comment:
   One way we can decouple this from specific environment variables (which may or may not exist), is to simply remove the `-cp` section, and set `CLASSPATH` above the call to `java`.
   Something like `export CLASSPATH="$at_shaded_jar:$CLASSPATH"`
   
   That way, the caller can simply set `CLASSPATH=/path/to/hadoop/confdir` prior to running the `accumulo-testing` command.
   
   We could also add a sanity check prior to running java to make sure that the `$CLASSPATH` contains a directory with `core-site.xml` and/or `hdfs-site.xml` (or whatever the Hadoop client configuration uses by default).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services