[jira] [Commented] (HBASE-5705) Introduce Protocol Buffer RPC engine

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540138#comment-13540138 ] 

stack commented on HBASE-5705:
------------------------------

It looks like this patch made it so that when we set up the proxy, we no longer ask the server what its version of the protocol is.  Instead we return the client's version of the protocol.  See below.

+  static long getProtocolVersion(Class<? extends VersionedProtocol> protocol)
+      throws NoSuchFieldException, IllegalAccessException {
+    Field versionField = protocol.getField("VERSION");
+    versionField.setAccessible(true);
+    return versionField.getLong(protocol);
+  }

Was expediency the reason the querying of server version was undone?  Something to be addressed later when VersionedProtocol was fixed up?

Thanks.
                
> Introduce Protocol Buffer RPC engine
> ------------------------------------
>
>                 Key: HBASE-5705
>                 URL: https://issues.apache.org/jira/browse/HBASE-5705
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC, master, migration, regionserver
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 5705-1.patch, 5705-2.1.patch, 5705-2.2.patch, 5705-2.3.patch
>
>
> Introduce Protocol Buffer RPC engine in the RPC core. Protocols that are PB aware can be made to go through this RPC engine. The approach, in my current thinking, would be similar to HADOOP-7773.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira