You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "owenowenisme (via GitHub)" <gi...@apache.org> on 2025/04/25 15:49:54 UTC
[PR] added set env in README [polaris]
owenowenisme opened a new pull request, #1461:
URL: https://github.com/apache/polaris/pull/1461
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
The instruction of how to set your own credentials is no where to be found in the polaris documents and repo markdowns, so according to the comment: https://github.com/apache/polaris/pull/1452#issuecomment-2829080942
Added the instruction of how to set credentials in README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061049547
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris as a direct java process via `./gradlew run`, you can set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,secret` where:
+ - `POLARIS` is the realm
+ - `root` is the CLIENT_ID
+ - `secret` is the CLIENT_SECRET
+ - If credentials are not set, it will use preset credentials `POLARIS,root,secret`
Review Comment:
This is fine, this part is only for `./gradlew run`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061051733
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris as a direct java process via `./gradlew run`, you can set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,secret` where:
Review Comment:
We could add this option `running java from shell` in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "owenowenisme (via GitHub)" <gi...@apache.org>.
owenowenisme commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061099726
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris as a direct java process via `./gradlew run`, you can set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,secret` where:
Review Comment:
@dimas-b I removed the [ **as a direct java process** ] part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2060501579
##########
README.md:
##########
@@ -71,6 +71,10 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
Review Comment:
Could you briefly mention that this run method uses preset `root:secret` credentials?
##########
README.md:
##########
@@ -71,6 +71,10 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
- `./regtests/run_spark_sql.sh` - To connect from Spark SQL. Here are some example commands to run in the Spark SQL shell:
+- Set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,s3cr3t` where:
Review Comment:
I think it might be best to disambiguate by saying `If you start Polaris as a direct `java` process with in-memory storage, set you own credentials ...`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061047124
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris as a direct java process via `./gradlew run`, you can set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,secret` where:
Review Comment:
Unfortunately this is not technically correct. `./gradle run` sets credentials via the `-Dpolaris.bootstrap.credentials` system property, which take precedence over the env. var :shrug:
When I said "direct java process" I mean running `java` from shell... IMO, running via Gradle is not "direct" :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2060517382
##########
README.md:
##########
@@ -71,6 +71,10 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
- `./regtests/run_spark_sql.sh` - To connect from Spark SQL. Here are some example commands to run in the Spark SQL shell:
+- Set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,s3cr3t` where:
Review Comment:
I assume this is only for `./gradlew run`. Can we move it under that bullet point so it's clear this environment variable (`POLARIS_BOOTSTRAP_CREDENTIALS`) is specifically for running Polaris locally via the Gradle task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #1461:
URL: https://github.com/apache/polaris/pull/1461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061136076
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris via `./gradlew run`, you can set your own credentials by specifying system property `./gradlew run -Dpolaris.bootstrap.credentials=POLARIS,root,secret` where:
Review Comment:
Let's make it more compacted, and remove a bullet level.
```suggestion
localhost:8181. This is also suitable for running regression tests, or for connecting with Spark. Set your own credentials by specifying system property `./gradlew run -Dpolaris.bootstrap.credentials=POLARIS,root,secret` where:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "owenowenisme (via GitHub)" <gi...@apache.org>.
owenowenisme commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061194268
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris via `./gradlew run`, you can set your own credentials by specifying system property `./gradlew run -Dpolaris.bootstrap.credentials=POLARIS,root,secret` where:
Review Comment:
Thanks @flyrain !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061051347
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris as a direct java process via `./gradlew run`, you can set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,secret` where:
Review Comment:
In that case, we should using this
```suggestion
- If you start Polaris as a direct java process via `./gradlew run`, you can set your own credentials by specifying system property `./gradlew run -Dpolaris.bootstrap.credentials=POLARIS,root,secret` where:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1461:
URL: https://github.com/apache/polaris/pull/1461#discussion_r2061047724
##########
README.md:
##########
@@ -69,7 +69,12 @@ Apache Polaris is built using Gradle with Java 21+ and Docker 27+.
- `./gradlew assemble` - To skip tests.
- `./gradlew test` - To run unit tests and integration tests.
- `./gradlew run` - To run the Polaris server locally; the server is reachable at
- localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ localhost:8181. This is also suitable for running regression tests, or for connecting with Spark.
+ - If you start Polaris as a direct java process via `./gradlew run`, you can set your own credentials using the environment variable `export POLARIS_BOOTSTRAP_CREDENTIALS=POLARIS,root,secret` where:
+ - `POLARIS` is the realm
+ - `root` is the CLIENT_ID
+ - `secret` is the CLIENT_SECRET
+ - If credentials are not set, it will use preset credentials `POLARIS,root,secret`
Review Comment:
The `POLARIS,root,secret` default applies only to `./gradlew run`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added set credentials env instruction in README [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #1461:
URL: https://github.com/apache/polaris/pull/1461#issuecomment-2832611003
Thanks @owenowenisme for the contribution! Thanks all for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org