You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/04/14 20:07:27 UTC
Review Request 33180: DRILL-2181 Throw proper error message when
flatten is used within an 'order by' or 'group by'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33180/
-----------------------------------------------------------
Review request for drill and Jason Altekruse.
Bugs: DRILL-2181
https://issues.apache.org/jira/browse/DRILL-2181
Repository: drill-git
Description
-------
Flatten function in order by, group by, distinct, aggregate functions is disabled
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 4830fe1
exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java f62f060
Diff: https://reviews.apache.org/r/33180/diff/
Testing
-------
tpch, functional (except for the cases which are meant to be removed)
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 33180: DRILL-2181 Throw proper error message when
flatten is used within an 'order by' or 'group by'
Posted by Jason Altekruse <al...@gmail.com>.
> On April 15, 2015, 4:37 p.m., Jason Altekruse wrote:
> > The changes look good, I think we may need to disable flatten in the project lists as well, if it is used as a sub-expression, such as: select flatten(repeated_int) + other_int_col
> >
> > Once we have general table table functions more formally defined I think we can safely include this, but for now I'm not sure that the precedence of flatten is well defined enough to allow this case either.
These cases are actually working well right now upon further review, we do not need to disable them.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33180/#review80207
-----------------------------------------------------------
On April 15, 2015, 12:42 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33180/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 12:42 a.m.)
>
>
> Review request for drill and Jason Altekruse.
>
>
> Bugs: DRILL-2181
> https://issues.apache.org/jira/browse/DRILL-2181
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Flatten function in order by, group by, distinct, aggregate functions is disabled
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 4830fe1
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java f62f060
>
> Diff: https://reviews.apache.org/r/33180/diff/
>
>
> Testing
> -------
>
> tpch, functional (except for the cases which are meant to be removed), unit
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 33180: DRILL-2181 Throw proper error message when
flatten is used within an 'order by' or 'group by'
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33180/#review80207
-----------------------------------------------------------
The changes look good, I think we may need to disable flatten in the project lists as well, if it is used as a sub-expression, such as: select flatten(repeated_int) + other_int_col
Once we have general table table functions more formally defined I think we can safely include this, but for now I'm not sure that the precedence of flatten is well defined enough to allow this case either.
- Jason Altekruse
On April 15, 2015, 12:42 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33180/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 12:42 a.m.)
>
>
> Review request for drill and Jason Altekruse.
>
>
> Bugs: DRILL-2181
> https://issues.apache.org/jira/browse/DRILL-2181
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Flatten function in order by, group by, distinct, aggregate functions is disabled
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 4830fe1
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java f62f060
>
> Diff: https://reviews.apache.org/r/33180/diff/
>
>
> Testing
> -------
>
> tpch, functional (except for the cases which are meant to be removed), unit
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 33180: DRILL-2181 Throw proper error message when
flatten is used within an 'order by' or 'group by'
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33180/#review80367
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Altekruse
On April 15, 2015, 12:42 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33180/
> -----------------------------------------------------------
>
> (Updated April 15, 2015, 12:42 a.m.)
>
>
> Review request for drill and Jason Altekruse.
>
>
> Bugs: DRILL-2181
> https://issues.apache.org/jira/browse/DRILL-2181
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Flatten function in order by, group by, distinct, aggregate functions is disabled
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 4830fe1
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java f62f060
>
> Diff: https://reviews.apache.org/r/33180/diff/
>
>
> Testing
> -------
>
> tpch, functional (except for the cases which are meant to be removed), unit
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 33180: DRILL-2181 Throw proper error message when
flatten is used within an 'order by' or 'group by'
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33180/
-----------------------------------------------------------
(Updated April 15, 2015, 12:42 a.m.)
Review request for drill and Jason Altekruse.
Changes
-------
update description
Bugs: DRILL-2181
https://issues.apache.org/jira/browse/DRILL-2181
Repository: drill-git
Description
-------
Flatten function in order by, group by, distinct, aggregate functions is disabled
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java 4830fe1
exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java f62f060
Diff: https://reviews.apache.org/r/33180/diff/
Testing (updated)
-------
tpch, functional (except for the cases which are meant to be removed), unit
Thanks,
Sean Hsuan-Yi Chu