You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Ramkumar Ramachandra <ar...@gmail.com> on 2010/09/29 08:04:21 UTC

Re: svn commit: r1002470 - /subversion/trunk/subversion/svnrdump/dump_editor.c

Hi Daniel,

Daniel Shahaf writes:
> So, you use a top-level pool but never destroy it?
> 
> That's not good.
> 
> Can you please find another solution?  (Either get the caller to
> guarantee something about the lifetime of the pool they provide (there
> is precedent for this), or figure out why close_edit() isn't called (and
> possibly patch the faulty driver).

Fixed in r1002502 :)

Thanks for the review.

-- Ram