You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/18 14:51:08 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #5570: Core: Make a shorthand for the rest catalog
Fokko opened a new pull request, #5570:
URL: https://github.com/apache/iceberg/pull/5570
I don't want to memorize the full classpath to the RESTCatalog, but now I already do. Let's make it easier for others in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #5570: Core: Make a shorthand for the rest catalog
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #5570:
URL: https://github.com/apache/iceberg/pull/5570#discussion_r949244633
##########
core/src/main/java/org/apache/iceberg/CatalogUtil.java:
##########
@@ -61,8 +61,11 @@ public class CatalogUtil {
public static final String ICEBERG_CATALOG_TYPE_HADOOP = "hadoop";
public static final String ICEBERG_CATALOG_TYPE_HIVE = "hive";
- public static final String ICEBERG_CATALOG_HIVE = "org.apache.iceberg.hive.HiveCatalog";
+ public static final String ICEBERG_CATALOG_TYPE_REST = "rest";
+
public static final String ICEBERG_CATALOG_HADOOP = "org.apache.iceberg.hadoop.HadoopCatalog";
+ public static final String ICEBERG_CATALOG_HIVE = "org.apache.iceberg.hive.HiveCatalog";
Review Comment:
I had to swap this one, to fix the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5570: Core: Make a shorthand for the rest catalog
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5570:
URL: https://github.com/apache/iceberg/pull/5570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org