You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by Jeff Eastman <jd...@windwardsolutions.com> on 2012/04/18 15:22:02 UTC

Eclipse-Lucene-Codestyle.xml

I just imported this file for use with Mahout and noticed it has 80 
column limits for source files and comments. IIRC, we agreed to use 120 
columns some time ago. When I use this file it does massive reformatting 
as a result. Does this file need to be updated?

Jeff

Re: Eclipse-Lucene-Codestyle.xml

Posted by Lance Norskog <go...@gmail.com>.
I can't. Please change it so that it does not word-wrap comments.
That's all I ask.

On Thu, Apr 19, 2012 at 7:34 AM, Jeff Eastman
<jd...@windwardsolutions.com> wrote:
> I looked at the comment formatting, and some of the formatting (e.g. Javadoc
> comments) seems necessary. It may be necessary to turn off Line Comment
> formatting in my last commit. Can you check that out and see if you agree?
>
>
> On 4/18/12 11:02 PM, Lance Norskog wrote:
>>
>> Also, make sure it does not reformat comments. A lot of comments are
>> written with "text formatting" instead of html and the eclipse
>> codestyle default word-wraps them.
>>
>> On Wed, Apr 18, 2012 at 8:41 AM, Ted Dunning<te...@gmail.com>
>>  wrote:
>>>
>>> Yes. It needs updating.
>>>
>>> Sent from my iPhone
>>>
>>> On Apr 18, 2012, at 6:22 AM, Jeff Eastman<jd...@windwardsolutions.com>
>>>  wrote:
>>>
>>>> I just imported this file for use with Mahout and noticed it has 80
>>>> column limits for source files and comments. IIRC, we agreed to use 120
>>>> columns some time ago. When I use this file it does massive reformatting as
>>>> a result. Does this file need to be updated?
>>>>
>>>> Jeff
>>
>>
>>
>



-- 
Lance Norskog
goksron@gmail.com

Re: Eclipse-Lucene-Codestyle.xml

Posted by Jeff Eastman <jd...@windwardsolutions.com>.
I looked at the comment formatting, and some of the formatting (e.g. 
Javadoc comments) seems necessary. It may be necessary to turn off Line 
Comment formatting in my last commit. Can you check that out and see if 
you agree?

On 4/18/12 11:02 PM, Lance Norskog wrote:
> Also, make sure it does not reformat comments. A lot of comments are
> written with "text formatting" instead of html and the eclipse
> codestyle default word-wraps them.
>
> On Wed, Apr 18, 2012 at 8:41 AM, Ted Dunning<te...@gmail.com>  wrote:
>> Yes. It needs updating.
>>
>> Sent from my iPhone
>>
>> On Apr 18, 2012, at 6:22 AM, Jeff Eastman<jd...@windwardsolutions.com>  wrote:
>>
>>> I just imported this file for use with Mahout and noticed it has 80 column limits for source files and comments. IIRC, we agreed to use 120 columns some time ago. When I use this file it does massive reformatting as a result. Does this file need to be updated?
>>>
>>> Jeff
>
>


Re: Eclipse-Lucene-Codestyle.xml

Posted by Lance Norskog <go...@gmail.com>.
Also, make sure it does not reformat comments. A lot of comments are
written with "text formatting" instead of html and the eclipse
codestyle default word-wraps them.

On Wed, Apr 18, 2012 at 8:41 AM, Ted Dunning <te...@gmail.com> wrote:
> Yes. It needs updating.
>
> Sent from my iPhone
>
> On Apr 18, 2012, at 6:22 AM, Jeff Eastman <jd...@windwardsolutions.com> wrote:
>
>> I just imported this file for use with Mahout and noticed it has 80 column limits for source files and comments. IIRC, we agreed to use 120 columns some time ago. When I use this file it does massive reformatting as a result. Does this file need to be updated?
>>
>> Jeff



-- 
Lance Norskog
goksron@gmail.com

Re: Eclipse-Lucene-Codestyle.xml

Posted by Ted Dunning <te...@gmail.com>.
Yes. It needs updating. 

Sent from my iPhone

On Apr 18, 2012, at 6:22 AM, Jeff Eastman <jd...@windwardsolutions.com> wrote:

> I just imported this file for use with Mahout and noticed it has 80 column limits for source files and comments. IIRC, we agreed to use 120 columns some time ago. When I use this file it does massive reformatting as a result. Does this file need to be updated?
> 
> Jeff