You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ricardozanini (via GitHub)" <gi...@apache.org> on 2024/01/17 20:33:06 UTC

[PR] [KIE-830] Make SonataFlow Operator build reproducible [incubator-kie-kogito-serverless-operator]

ricardozanini opened a new pull request, #357:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/357

   <!--
   
   Welcome to the SonataFlow Operator! Before contributing, make sure to:
   
   - Rebase your branch on the latest upstream main
   - Link any relevant issues, PR's, or documentation
   - Check that the commit message is concise and helpful:
       - When fixing an issue, add "Closes #<ISSUE_NUMBER>"
   - Follow the below checklist 
   
   -->
   
   **Description of the change:**
   See https://github.com/apache/incubator-kie-issues/issues/830.
   
   TODO:
   
   - [ ] - Test different build machines with [diffoci](https://github.com/reproducible-containers/diffoci)
   - [ ] - Verify Buildkit on CI
   
   **Motivation for the change:**
   Closes https://github.com/apache/incubator-kie-issues/issues/830
   
   **Checklist**
   
   - [ ] Add or Modify a unit test for your change
   - [ ] Have you verified that tall the tests are passing?
   
   <details>
   <summary>
   How to backport a pull request to a different branch?
   </summary>
   
   In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
   
   > **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
   
   Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
   
   If something goes wrong, the author will be notified and at this point a manual backporting is needed.
   
   > **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [KIE-830] Make SonataFlow Operator build reproducible [incubator-kie-kogito-serverless-operator]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #357:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/357#issuecomment-1898617187

   I was able to produce semantically equal files:
   
   ```
   diffoci diff --platform=linux/amd64  quay.io/ricardozanini/kogito-serverless-operator-nightly:latest quay.io/wmedvede/sonataflow-operator:latest
   INFO[0000] Target platforms: [linux/amd64]
   TYPE    NAME                                                    INPUT-0                                                             INPUT-1
   Desc    application/vnd.docker.distribution.manifest.v2+json    508a8efd643809f806504af28e100f610c0abf984cb6cdcc8f4f1bea14125ea8    d8d59be7f2b6dcb47a6be94bb0038eeaf026ad977e7180eecff70ba46b87a18b
   Mani    ctx:/manifest                                           ?                                                                   ?
   Desc    application/vnd.docker.container.image.v1+json          66cdb1cce69f54c83abd88ea5b4cc2f5bc2734672955ce8d04e91a47d0c54cd5    2d2196b3af3a0ecd7002754e297328f12f511fcf35ccdb86236e51d0c2cd4385
   Cfg     ctx:/config/config                                      ?                                                                   ?
   Desc    application/vnd.docker.image.rootfs.diff.tar.gzip       b4d49c25d2f03e2063f369c203ec7abef0192c7ac2ca1f71aca5419d6f43ef4f    67776c3576648a89a6840fb791af3e1f8d6037cdc84691122c04ea5ee610993a
   File    usr/local/bin/                                          2024-01-17 17:16:21 -0300 -03                                       2024-01-18 10:53:37 -0300 -03
   File    usr/local/bin/manager                                   2024-01-17 16:55:46 -0300 -03                                       2024-01-18 10:53:37 -0300 -03
   ```
   
   The diffs are:
   
   - Docker manifests since they were build on different systems. Same systems, should produce the same result. I'm waiting for a friend to test on their end.
   - The operator's file timestamp. That we can force during the build, I'm gonna try a few things.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [KIE-830] Make SonataFlow Operator build reproducible [incubator-kie-kogito-serverless-operator]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #357:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/357#issuecomment-1900557418

   Guys, the images are identical now:
   
   ```
   ➜  ~ docker run --entrypoint /bin/bash --rm -it quay.io/kiegroup/kogito-serverless-operator-nightly:latest
   bash-5.1$ ls -la manager
   -rwxr-xr-x 1 root root 69959642 Jan 19 12:48 manager
   bash-5.1$ ^C
   bash-5.1$
   exit
   ➜  ~ docker run --entrypoint /bin/bash --rm -it quay.io/wmedvede/kogito-serverless-operator-nightly:latest
   bash-5.1$ ls -la manager
   -rwxr-xr-x 1 root root 69959642 Jan 19 12:48 manager
   bash-5.1$
   ```
   
   Merging!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [KIE-830] Make SonataFlow Operator build reproducible [incubator-kie-kogito-serverless-operator]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini merged PR #357:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [KIE-830] Make SonataFlow Operator build reproducible [incubator-kie-kogito-serverless-operator]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #357:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/357#issuecomment-1899037351

   @porcelli the timestamp workaround is not working. The images are semantically equal per `diffoci`, but the timestamp still differs. I'll take a look tomorrow. 
   
   But, I think we should touch IPMC about this. How do we guarantee the images are reproducible? Is the `diffoci` output enough to validate? I need a benchmark. Can you ask around?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [KIE-830] Make SonataFlow Operator build reproducible [incubator-kie-kogito-serverless-operator]

Posted by "ederign (via GitHub)" <gi...@apache.org>.
ederign commented on PR #357:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/357#issuecomment-1896676099

   docker pull quay.io/ederignatowicz/kogito-serverless-operator-nightly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] [KIE-830] Make SonataFlow Operator build reproducible [incubator-kie-kogito-serverless-operator]

Posted by "jordigilh (via GitHub)" <gi...@apache.org>.
jordigilh commented on code in PR #357:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/357#discussion_r1458889295


##########
.github/workflows/e2e.yml:
##########
@@ -12,7 +12,11 @@ on:
       - ".ci/jenkins/**"
 
 env:
-  GO_VERSION: 1.19
+  GO_VERSION: 1.21
+  # Kubernetes version should aligned with OCP LTS, aka OCP 4.10 (k8s 1.23) for now
+  # https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.23.md
+  # WARNING: kindest/node is not always existing with given version ...
+  KUBERNETES_VERSION: v1.26.3

Review Comment:
   I'm not sure this is used anymore. The kubernetes version now is linked to the kind version (currently at v0.20.0 which [uses](https://github.com/kubernetes-sigs/kind/releases/tag/v0.20.0) v1.27.3).
   What do you think to capture the kind version to download instead? If so, take care of changing the Makefile target to capture it from the environment if not provided. Right now is hardcoded to v0.20.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org