[GitHub] [iceberg] rdblue commented on a change in pull request #2826: Build: Upgrade to Gradle 7.x

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r707424996



##########
File path: build.gradle
##########
@@ -201,44 +202,46 @@ project(':iceberg-bundled-guava') {
 
 project(':iceberg-api') {
   dependencies {
-    compile project(path: ':iceberg-bundled-guava', configuration: 'shadow')
-    compileOnly "com.google.errorprone:error_prone_annotations:2.3.3"
-    testCompile "org.apache.avro:avro"
+    implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+    compileOnly "com.google.errorprone:error_prone_annotations"
+    testImplementation "org.apache.avro:avro"
   }
 }
 
 project(':iceberg-common') {
   dependencies {
-    compile project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+    implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
   }
 }
 
 project(':iceberg-core') {
   dependencies {
-    compile project(':iceberg-api')
-    compile project(':iceberg-common')
+    implementation project(':iceberg-api')
+    implementation project(':iceberg-common')
+    implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
 
-    compile("org.apache.avro:avro") {
+    implementation("org.apache.avro:avro") {
       exclude group: 'org.tukaani' // xz compression is not supported
     }
 
-    compile "com.fasterxml.jackson.core:jackson-databind"
-    compile "com.fasterxml.jackson.core:jackson-core"
-    compile "com.github.ben-manes.caffeine:caffeine"
+    implementation "com.fasterxml.jackson.core:jackson-databind"
+    implementation "com.fasterxml.jackson.core:jackson-core"
+    implementation "com.github.ben-manes.caffeine:caffeine"
     compileOnly("org.apache.hadoop:hadoop-client") {
       exclude group: 'org.apache.avro', module: 'avro'
       exclude group: 'org.slf4j', module: 'slf4j-log4j12'
     }
 
-    testCompile "org.xerial:sqlite-jdbc"
-    testCompile project(path: ':iceberg-api', configuration: 'testArtifacts')
+    testImplementation "org.xerial:sqlite-jdbc"
+    testImplementation project(path: ':iceberg-api', configuration: 'testArtifacts')
   }
 }
 
 project(':iceberg-data') {
   dependencies {
-    compile project(':iceberg-api')
-    compile project(':iceberg-core')
+    implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
+    implementation project(':iceberg-api')

Review comment:
       I think this should be an `api` dependency because these classes are used in the API of `iceberg-data`. For example, `iceberg-api` includes the expressions, which are passed into `IcebergGenerics`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org