You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Joel Halbert (JIRA)" <de...@tapestry.apache.org> on 2008/10/21 19:31:46 UTC

[jira] Created: (TAPESTRY-2713) When @Property generated accessor methods will overwrite user generated accessors then either warn the user or do not generate them.

When @Property generated  accessor methods will overwrite user generated accessors then either warn the user or do not generate them.
-------------------------------------------------------------------------------------------------------------------------------------

                 Key: TAPESTRY-2713
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2713
             Project: Tapestry
          Issue Type: Improvement
    Affects Versions: unspecified
            Reporter: Joel Halbert
            Priority: Minor
             Fix For: unspecified


Occasionally I get  stung when I declare an @Property on my page and then at some point later I create custom accessor methods for the property - which of course are never invoked since the @Property generated code wipes over them.

I realise this is pretty minor, and all of my own doing, but I think a small amount of pain might be saved if T5 either:

a) warns when @Property is declared at the same time as accessor methods for the property are defined.
b) does not generate accessor methods when user defined methods are already present.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-303) When @Property generated accessor methods will overwrite user generated accessors then either warn the user or do not generate them.

Posted by "Geoff Callender (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641781#action_12641781 ] 

Geoff Callender commented on TAP5-303:
--------------------------------------

An error sounds good to me.

> When @Property generated  accessor methods will overwrite user generated accessors then either warn the user or do not generate them.
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-303
>                 URL: https://issues.apache.org/jira/browse/TAP5-303
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Joel Halbert
>            Priority: Minor
>
> Occasionally I get  stung when I declare an @Property on my page and then at some point later I create custom accessor methods for the property - which of course are never invoked since the @Property generated code wipes over them.
> I realise this is pretty minor, and all of my own doing, but I think a small amount of pain might be saved if T5 either:
> a) warns when @Property is declared at the same time as accessor methods for the property are defined.
> b) does not generate accessor methods when user defined methods are already present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-303) When @Property generated accessor methods will overwrite user generated accessors then either warn the user or do not generate them.

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641666#action_12641666 ] 

Howard M. Lewis Ship commented on TAP5-303:
-------------------------------------------

Warnings are useless, as they are universally ignored. If implemented, this would have to be an error.

> When @Property generated  accessor methods will overwrite user generated accessors then either warn the user or do not generate them.
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-303
>                 URL: https://issues.apache.org/jira/browse/TAP5-303
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Joel Halbert
>            Priority: Minor
>
> Occasionally I get  stung when I declare an @Property on my page and then at some point later I create custom accessor methods for the property - which of course are never invoked since the @Property generated code wipes over them.
> I realise this is pretty minor, and all of my own doing, but I think a small amount of pain might be saved if T5 either:
> a) warns when @Property is declared at the same time as accessor methods for the property are defined.
> b) does not generate accessor methods when user defined methods are already present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Closed: (TAP5-303) When @Property generated accessor methods will overwrite user generated accessors then either warn the user or do not generate them.

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-303.
-------------------------------------

    Resolution: Duplicate
      Assignee: Howard M. Lewis Ship

TAP5-301

> When @Property generated  accessor methods will overwrite user generated accessors then either warn the user or do not generate them.
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-303
>                 URL: https://issues.apache.org/jira/browse/TAP5-303
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Joel Halbert
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>
> Occasionally I get  stung when I declare an @Property on my page and then at some point later I create custom accessor methods for the property - which of course are never invoked since the @Property generated code wipes over them.
> I realise this is pretty minor, and all of my own doing, but I think a small amount of pain might be saved if T5 either:
> a) warns when @Property is declared at the same time as accessor methods for the property are defined.
> b) does not generate accessor methods when user defined methods are already present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-303) When @Property generated accessor methods will overwrite user generated accessors then either warn the user or do not generate them.

Posted by "Joel Halbert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641806#action_12641806 ] 

Joel Halbert commented on TAP5-303:
-----------------------------------

An error sounds good, then the user would have to explicitly add the "read=false" / "write=false" properties to the annotation to disable the auto generation of methods, if this was the intention.

> When @Property generated  accessor methods will overwrite user generated accessors then either warn the user or do not generate them.
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-303
>                 URL: https://issues.apache.org/jira/browse/TAP5-303
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Joel Halbert
>            Priority: Minor
>
> Occasionally I get  stung when I declare an @Property on my page and then at some point later I create custom accessor methods for the property - which of course are never invoked since the @Property generated code wipes over them.
> I realise this is pretty minor, and all of my own doing, but I think a small amount of pain might be saved if T5 either:
> a) warns when @Property is declared at the same time as accessor methods for the property are defined.
> b) does not generate accessor methods when user defined methods are already present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAP5-303) When @Property generated accessor methods will overwrite user generated accessors then either warn the user or do not generate them.

Posted by "Andy Blower (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641818#action_12641818 ] 

Andy Blower commented on TAP5-303:
----------------------------------

I don't ignore warnings, so your theory of universally ignored warnings is disproved. ;-)

> When @Property generated  accessor methods will overwrite user generated accessors then either warn the user or do not generate them.
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-303
>                 URL: https://issues.apache.org/jira/browse/TAP5-303
>             Project: Tapestry 5
>          Issue Type: Improvement
>            Reporter: Joel Halbert
>            Priority: Minor
>
> Occasionally I get  stung when I declare an @Property on my page and then at some point later I create custom accessor methods for the property - which of course are never invoked since the @Property generated code wipes over them.
> I realise this is pretty minor, and all of my own doing, but I think a small amount of pain might be saved if T5 either:
> a) warns when @Property is declared at the same time as accessor methods for the property are defined.
> b) does not generate accessor methods when user defined methods are already present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2713) When @Property generated accessor methods will overwrite user generated accessors then either warn the user or do not generate them.

Posted by "Joel Halbert (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Halbert updated TAPESTRY-2713:
-----------------------------------

    Affects Version/s:     (was: unspecified)
                       5.0.16

> When @Property generated  accessor methods will overwrite user generated accessors then either warn the user or do not generate them.
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-2713
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2713
>             Project: Tapestry
>          Issue Type: Improvement
>    Affects Versions: 5.0.16
>            Reporter: Joel Halbert
>            Priority: Minor
>             Fix For: unspecified
>
>
> Occasionally I get  stung when I declare an @Property on my page and then at some point later I create custom accessor methods for the property - which of course are never invoked since the @Property generated code wipes over them.
> I realise this is pretty minor, and all of my own doing, but I think a small amount of pain might be saved if T5 either:
> a) warns when @Property is declared at the same time as accessor methods for the property are defined.
> b) does not generate accessor methods when user defined methods are already present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org