You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mehrdad Nurolahzade <me...@nurolahzade.com> on 2016/12/27 21:36:27 UTC

Review Request 55056: AURORA-1834 Expose stats on undelivered event bus events

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55056/
-----------------------------------------------------------

Review request for Aurora, Stephan Erb and Zameer Manji.


Bugs: AURORA-1834
    https://issues.apache.org/jira/browse/AURORA-1834


Repository: aurora


Description
-------

AURORA-1834 Expose stats on undelivered event bus events


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java f9c8a5786283c288d91a53bc793ee16373adf0e3 
  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 2676e3c685b59b1ef5c62f494729fd413beac74b 

Diff: https://reviews.apache.org/r/55056/diff/


Testing
-------

```
curl 192.168.33.7:8081/vars | grep event_bus
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 34413    0 34413    0     0  5220k      0 --:--:-- --:--:-- --:--:-- 5601k
event_bus_dead_events 0
event_bus_exceptions 0
```


Thanks,

Mehrdad Nurolahzade


Re: Review Request 55056: AURORA-1834 Expose stats on undelivered event bus events

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55056/#review160195
-----------------------------------------------------------


Ship it!




Master (31f095d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 27, 2016, 9:36 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55056/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2016, 9:36 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Bugs: AURORA-1834
>     https://issues.apache.org/jira/browse/AURORA-1834
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1834 Expose stats on undelivered event bus events
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java f9c8a5786283c288d91a53bc793ee16373adf0e3 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 2676e3c685b59b1ef5c62f494729fd413beac74b 
> 
> Diff: https://reviews.apache.org/r/55056/diff/
> 
> 
> Testing
> -------
> 
> ```
> curl 192.168.33.7:8081/vars | grep event_bus
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100 34413    0 34413    0     0  5220k      0 --:--:-- --:--:-- --:--:-- 5601k
> event_bus_dead_events 0
> event_bus_exceptions 0
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Re: Review Request 55056: AURORA-1834 Expose stats on undelivered event bus events

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55056/#review160198
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Dec. 27, 2016, 10:36 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55056/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2016, 10:36 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Bugs: AURORA-1834
>     https://issues.apache.org/jira/browse/AURORA-1834
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1834 Expose stats on undelivered event bus events
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java f9c8a5786283c288d91a53bc793ee16373adf0e3 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 2676e3c685b59b1ef5c62f494729fd413beac74b 
> 
> Diff: https://reviews.apache.org/r/55056/diff/
> 
> 
> Testing
> -------
> 
> ```
> curl 192.168.33.7:8081/vars | grep event_bus
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100 34413    0 34413    0     0  5220k      0 --:--:-- --:--:-- --:--:-- 5601k
> event_bus_dead_events 0
> event_bus_exceptions 0
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Re: Review Request 55056: AURORA-1834 Expose stats on undelivered event bus events

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55056/#review160197
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On Dec. 27, 2016, 1:36 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55056/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2016, 1:36 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Bugs: AURORA-1834
>     https://issues.apache.org/jira/browse/AURORA-1834
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1834 Expose stats on undelivered event bus events
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java f9c8a5786283c288d91a53bc793ee16373adf0e3 
>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 2676e3c685b59b1ef5c62f494729fd413beac74b 
> 
> Diff: https://reviews.apache.org/r/55056/diff/
> 
> 
> Testing
> -------
> 
> ```
> curl 192.168.33.7:8081/vars | grep event_bus
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100 34413    0 34413    0     0  5220k      0 --:--:-- --:--:-- --:--:-- 5601k
> event_bus_dead_events 0
> event_bus_exceptions 0
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>