[jira] [Commented] (GEODE-8394) Client sends partial data during retry

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171196#comment-17171196 ] 

ASF GitHub Bot commented on GEODE-8394:
---------------------------------------

agingade opened a new pull request #5424:
URL: https://github.com/apache/geode/pull/5424


   This change rewinds the message part on command failure. Without this during retry on failure, the message (Part) is sent from the place where it was previously failed, instead of starting from the beginning, causing it to transmit partial data.  
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [Y] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [Y] Is your initial contribution a single, squashed commit?
   
   - [Y] Does `gradlew build` run cleanly?
   
   - [Y] Have you written or updated unit tests to verify your changes?
   
   - [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Client sends partial data during retry
> --------------------------------------
>
>                 Key: GEODE-8394
>                 URL: https://issues.apache.org/jira/browse/GEODE-8394
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>    Affects Versions: 1.14.0
>            Reporter: Anilkumar Gingade
>            Assignee: Anilkumar Gingade
>            Priority: Major
>              Labels: GeodeOperationAPI
>
> When executing the command, java client sends the command in the form of message (Parts). If there is a failure during the send, it retries number of times based on the retry-attempt setting.
> If there is a failure in the first attempt due to Exception (IOException, EOFException - read timeout); during the second attempt the client is sending partial data, instead of the complete data.
> This could be reproduced by setting a small read-timeout and large object (Put).
> Because of this, the put from client succeeds by creating partial data on the server cache. Since the data is stored in serialized form, there is no exception thrown during put() operation, giving an impression that put operation is successful. 
> The workaround for now is to have large read-timeout setting; while trying to send a large object.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)