You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/07 23:49:17 UTC

[GitHub] [helix] kaisun2000 commented on pull request #1449: HelixClusterVerifier verify() with default waitTillVerify time -- part one

kaisun2000 commented on pull request #1449:
URL: https://github.com/apache/helix/pull/1449#issuecomment-705251143


   This diff is approved. Please help to merge into trunk
   
   >fix #1448 part 1
   HelixClusterVerifier verify() and related method may return
   pre-maturely. The reason is that the verify the converging stable
   condition too early before controller has a chance to make
   change. Basically the previous stable state is mistaken as the
   expected next stable state.
   
   We fix this issue by adding waitTillVerify() timeout in
   construction time of verifier.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org