You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "wwj6591812 (via GitHub)" <gi...@apache.org> on 2024/12/29 13:48:33 UTC

Re: [PR] [core] Alter table set option with empty key filter [paimon]

wwj6591812 commented on code in PR #4797:
URL: https://github.com/apache/paimon/pull/4797#discussion_r1899134637


##########
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##########
@@ -547,6 +549,18 @@ private void validateCustomTablePath(Map<String, String> options) {
         }
     }
 
+    private List<SchemaChange> filterNonEmptyKeyInSchemaChange(List<SchemaChange> changes) {
+        List<SchemaChange> schemaChanges = new ArrayList<>();
+        for (SchemaChange schemaChange : changes) {
+            if (schemaChange instanceof SchemaChange.SetOption
+                    && StringUtils.isEmpty(((SchemaChange.SetOption) schemaChange).key())) {

Review Comment:
   What about throw a exception instead of continue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org