renaming svn_io_file_printf to svn_io_file_printf_from_utf8

[Erik Huelsmann <e....@gmx.net>]

In libsvn_diff there are a lot of calls to svn_io_file_printf which
translates from utf8 to locale and does a printf to the specified file. Conforming to
the convention in svn_utf8_*, I would like to rename the function to
svn_io_file_printf_from_utf8. After doing so, I can then implement a 'true' wrapper
function which does raw printf on the data passed.  The wrapper would be
around apr_file_printf just as the recent wrappers I implemented in the
svn_io_file_* range of function names. Calls in libsvn_diff which now call
apr_file_printf could then be replaced by calls to svn_io_file_printf. That way a ###
comment can be eliminated and the (currently discarded) return values can be
wrapped in SVN_ERR.

Basically there is nothing different in the above proposal then I have been
doing all along, except for the fact that I now want to change a function's
name. Until now I only changed function's return value types.

Anyone opposed to making this change?

bye,

Erik.

PS: I could make the patch and submit it for review if the above is
unclear....

-- 
+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: renaming svn_io_file_printf to svn_io_file_printf_from_utf8

[Sander Striker <st...@apache.org>]

On Fri, 2003-12-05 at 00:14, Branko Čibej wrote:
> Erik Huelsmann wrote:
> 
> >In libsvn_diff there are a lot of calls to svn_io_file_printf which
> >translates from utf8 to locale and does a printf to the specified file.
> >
> Which is especially bad when the "file" happens to be the Win32 console
> output, which typically uses a different encoding than the "native".
> Renaming this file won't help. We need a completely different output
> mechanism if we want this code to ever work correctly in the Windows
> command line.
> 
> 
> >Anyone opposed to making this change?
> >  
> >
> I'd rather change the libsvn_diff API to accept a svn_stream handle.
> That way GUI clients can use the diff output formatters in libsvn_diff, too.

You mean the svn_diff_file_output_unified and svn_diff_file_output_merge
APIs?  I don't see why not.  I'll incorporate this change somewhere at
the end of the day.


Sander


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: renaming svn_io_file_printf to svn_io_file_printf_from_utf8

[Branko Čibej <br...@xbc.nu>]

Erik Huelsmann wrote:

>In libsvn_diff there are a lot of calls to svn_io_file_printf which
>translates from utf8 to locale and does a printf to the specified file.
>
Which is especially bad when the "file" happens to be the Win32 console
output, which typically uses a different encoding than the "native".
Renaming this file won't help. We need a completely different output
mechanism if we want this code to ever work correctly in the Windows
command line.


>Anyone opposed to making this change?
>  
>
I'd rather change the libsvn_diff API to accept a svn_stream handle.
That way GUI clients can use the diff output formatters in libsvn_diff, too.


-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org